Skip to content

chore: fix ConstantFolding rule exclusion for benchmarks #4689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comphead merged 1 commit into from
Jun 19, 2026
+6 −3
Merged

chore: fix ConstantFolding rule exclusion for benchmarks #4689

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion spark/src/test/scala/org/apache/spark/sql/benchmark/CometBenchmarkBase.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,8 @@ trait CometBenchmarkBase
val cometExecConfigs = Map(
CometConf.COMET_ENABLED.key -> "true",
CometConf.COMET_EXEC_ENABLED.key -> "true",
"spark.sql.optimizer.constantFolding.enabled" -> "false") ++ extraCometConfigs
"spark.sql.optimizer.excludedRules" ->
"org.apache.spark.sql.catalyst.optimizer.ConstantFolding") ++ extraCometConfigs

// Check that the plan is fully Comet native before running the benchmark
withSQLConf(cometExecConfigs.toSeq: _*) {
Expand Down
3 changes: 2 additions & 1 deletion spark/src/test/scala/org/apache/spark/sql/benchmark/CometRegExpBenchmark.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ object CometRegExpBenchmark extends CometBenchmarkBase {
val baseExec = Map(
CometConf.COMET_ENABLED.key -> "true",
CometConf.COMET_EXEC_ENABLED.key -> "true",
"spark.sql.optimizer.constantFolding.enabled" -> "false")
"spark.sql.optimizer.excludedRules" ->
"org.apache.spark.sql.catalyst.optimizer.ConstantFolding")

benchmark.addCase("Comet (Exec, native Rust regex)") { _ =>
val configs = baseExec ++ Map(CometConf.getExprAllowIncompatConfigKey("RLike") -> "true")
Expand Down
3 changes: 2 additions & 1 deletion spark/src/test/scala/org/apache/spark/sql/benchmark/CometRegExpExtractBenchmark.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ object CometRegExpExtractBenchmark extends CometBenchmarkBase {
val baseExec = Map(
CometConf.COMET_ENABLED.key -> "true",
CometConf.COMET_EXEC_ENABLED.key -> "true",
"spark.sql.optimizer.constantFolding.enabled" -> "false")
"spark.sql.optimizer.excludedRules" ->
"org.apache.spark.sql.catalyst.optimizer.ConstantFolding")

benchmark.addCase("Comet (Exec, native Rust regex)") { _ =>
val configs =
Expand Down
Loading