fix: gate element_at input types#4702
Closed
manuzhang wants to merge 0 commit into
Closed
Conversation
manuzhang
force-pushed
the
codex/issue-4505-element-at-map
branch
from
e9c6bc3 to
fa79f2b
Compare
Member
|
Thanks for working on this @manuzhang. I think this PR may conflict with #4697? |
manuzhang
force-pushed
the
codex/issue-4505-element-at-map
branch
from
fa79f2b to
de3beef
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #4505.
This PR does not address #4680 because that follow-up is assigned separately.
Rationale for this change
element_atsupports array and map inputs in Spark, but Comet only implements the array path. Reporting the map-input fallback throughgetSupportLevelkeeps unsupported map inputs documented and handled consistently.What changes are included in this PR?
MapTypeinput fallback forElementAtintogetSupportLevel.element_aton map inputs.How are these changes tested?
Co-authored-by: @codex