Draft
Conversation
alamb
reviewed
Apr 8, 2026
| future: BoxFuture<'static, Result<Box<dyn MorselPlanner>>>, | ||
| } | ||
|
|
||
| impl PendingMorselPlanner { |
alamb
reviewed
Apr 8, 2026
Comment on lines
+116
to
+117
| pub struct PendingMorselPlanner { | ||
| future: BoxFuture<'static, Result<Box<dyn MorselPlanner>>>, |
Contributor
There was a problem hiding this comment.
I think this is the key change -- this returns the MorselPlanner rather than relying on the caller to hold on to it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idea here is to encode the API contract into the type system