Open
Conversation
…t is needed The SQL planner handles aliasing via projection, so ResolveGroupingFunction never sees Expr::Alias in SQL queries. Only the DataFrame API produces that expression shape, making the SQL test insufficient as a regression test. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes DataFrame API aggregation planning when grouping() is wrapped in an Expr::Alias, aligning behavior with SQL planning and preventing a physical planning error for GROUPING.
Changes:
- Extend
ResolveGroupingFunctionto recognizegrouping()when wrapped inExpr::Alias. - Update grouping-function detection to recurse through alias nodes.
- Add a DataFrame regression test covering
grouping(col).alias(...)in aggregates.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| datafusion/optimizer/src/analyzer/resolve_grouping_function.rs | Teach the analyzer rule to detect/replace aliased grouping() expressions. |
| datafusion/core/tests/dataframe/mod.rs | Add regression coverage for aliased grouping() via the DataFrame API. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When you have an alias on
groupingfunction via dataframe API, you get an error. This resolves that error.What changes are included in this PR?
Check for alias expressions in optimizer.
Add unit tests.
Are these changes tested?
Unit test added, including a note on why a SQL logic test will not cover this case.
Are there any user-facing changes?
None