DRILL-4606: Add DrillClient.Builder class#480
Closed
sudheeshkatkam wants to merge 2 commits intoapache:masterfrom
Closed
DRILL-4606: Add DrillClient.Builder class#480sudheeshkatkam wants to merge 2 commits intoapache:masterfrom
sudheeshkatkam wants to merge 2 commits intoapache:masterfrom
Conversation
Contributor
Author
|
@hnfgns can you please review? |
sudheeshkatkam
force-pushed
the
DRILL-4606
branch
2 times, most recently
from
bbcf839 to
fc018a7
Compare
Contributor
Author
|
Rebased on latest master. @parthchandra and @adeneche please review? |
| } | ||
| }; | ||
|
|
||
| this.supportComplexTypes = builder.supportComplexTypes; |
Contributor
There was a problem hiding this comment.
supportComplexTypes used to be initialized from the config object, and now it will be true by default unless we explicitly set it in the builder.
Contributor
There was a problem hiding this comment.
This is probably OK. This is the Java client and the client does, in fact, support complex types.
added 2 commits
August 10, 2016 15:14
+ Merge DrillAutoCloseables and AuthCloseables + Remove unused imports + Expand * imports
+ Add DrillClient.Builder helper class to create DrillClient objects + Deprecate 8 constructors and DrillClientFactory + Reorganize and document DrillClient
sudheeshkatkam
force-pushed
the
DRILL-4606
branch
from
fc018a7 to
8cc6bc9
Compare
Contributor
Author
|
@parthchandra please review. |
Contributor
|
+1 |
Member
|
Looks like these changes were added to #565, so closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.