Skip to content

[FLINK-36298][table] Fix NullPointerException in metadata query supplier on fresh threads#28247

Open
Au-Miner wants to merge 1 commit into
apache:masterfrom
Au-Miner:FLINK-36298
Open

[FLINK-36298][table] Fix NullPointerException in metadata query supplier on fresh threads#28247
Au-Miner wants to merge 1 commit into
apache:masterfrom
Au-Miner:FLINK-36298

Conversation

@Au-Miner
Copy link
Copy Markdown
Contributor

What is the purpose of the change

Fix a flaky NullPointerException raised from Calcite's RelMetadataQueryBase.getMetadataHandlerProvider during Volcano-based query optimization, surfaced as a PyFlink test failure when planning runs on a thread that has never initialized THREAD_PROVIDERS.

Brief change log

  • Update the metadata query supplier in FlinkRelOptClusterFactory.create to set RelMetadataQueryBase.THREAD_PROVIDERS before constructing FlinkRelMetadataQuery, so the parent RelMetadataQuery constructor sees a non-null JaninoRelMetadataProvider regardless of which thread invokes the supplier.
  • Cache the JaninoRelMetadataProvider instance at object init to avoid re-wrapping FlinkDefaultRelMetadataProvider on every supplier call.

Verifying this change

Added FlinkRelOptClusterFactoryTest#testMetadataQuerySupplierUsableOnFreshThread, which spawns a fresh thread, clears THREAD_PROVIDERS, invokes the cluster's supplier, and asserts that the produced RelMetadataQuery has a non-null metadataHandlerProvider — the precondition that prevents the NPE in subsequent metadata calls.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API, i.e., is any changed class annotated with @Public(Evolving): no
  • The serializers: no
  • The runtime per-record code paths (performance sensitive): no
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
  • The S3 file system connector: no

Documentation

  • Does this pull request introduce a new feature? no
  • If yes, how is the feature documented? not applicable

@flinkbot
Copy link
Copy Markdown
Collaborator

flinkbot commented May 25, 2026

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants