HBASE-29289: Make hbase master ui show cluster client connections info#8058
Draft
hingu-8103 wants to merge 1 commit intoapache:masterfrom
Draft
HBASE-29289: Make hbase master ui show cluster client connections info#8058hingu-8103 wants to merge 1 commit intoapache:masterfrom
hingu-8103 wants to merge 1 commit intoapache:masterfrom
Conversation
hingu-8103
commented
Apr 10, 2026
|
|
||
| // Verify that the connection is unregistered | ||
| connections = registry.getClientConnections(); | ||
| assertTrue(connections.size() <= initialSize); |
Contributor
Author
There was a problem hiding this comment.
I believe this assertion might introduce flakiness in tests when there are new client connections happens during this test execution by some other test case which is running parallel.
How should i make test robust in this kind of scenarios ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added ClientConnectionInfo object which tracks client connection info for each client connections and also added ClientConnectionRegistry to track all the active ClientConnectionInfo.
I have added basic tests to test the change and also manually tested on the cluster.