HIVE-25948: Iceberg: Enable cost-based selection between Fanout and Clustered writers using column stats NDV#6389
Merged
deniskuzZ merged 5 commits intoapache:masterfrom Apr 9, 2026
Merged
Conversation
deniskuzZ
changed the title
deniskuzZ
force-pushed
the
HIVE-25948
branch
2 times, most recently
from
01fef8e to
f661d63
Compare
deniskuzZ
changed the title
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
asf-ci-hive
added
tests pending
tests unstable
and removed
tests unstable
tests pending
labels
asf-ci-hive
added
tests unstable
tests pending
tests passed
and removed
tests pending
tests unstable
labels
okumin
reviewed
Apr 6, 2026
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java
Outdated
Show resolved
Hide resolved
ql/src/java/org/apache/hadoop/hive/ql/optimizer/SortedDynPartitionOptimizer.java
Outdated
Show resolved
Hide resolved
asf-ci-hive
added
tests unstable
tests pending
tests passed
and removed
tests pending
tests unstable
tests passed
labels
deniskuzZ
force-pushed
the
HIVE-25948
branch
2 times, most recently
from
115aef2 to
1e12e6e
Compare
asf-ci-hive
added
tests failed
tests pending
tests unstable
and removed
tests pending
tests failed
labels
|
Member
Author
|
hi @okumin, thanks for the review! i've addressed the comments, please take a final look before we merge |
okumin
approved these changes
Apr 8, 2026
Comment on lines
+875
to
+883
| case -1: | ||
| return false; | ||
| case 0: | ||
| break; | ||
| case 1: | ||
| return true; | ||
| default: | ||
| MAX_WRITERS = threshold; | ||
| break; |
Contributor
There was a problem hiding this comment.
We may update checkstyle.xml if we prefer it, but it is out of scope of this PR and reconsider it later
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Cost-based selection between Fanout and Clustered writers
Why are the changes needed?
Perf optimization
Does this PR introduce any user-facing change?
No
How was this patch tested?
mvn test -Dtest=TestIcebergCliDriver -Dqfile=dynamic_partition_writes.q