HIVE-29546: Iceberg: [V3] Support of ROW LINEAGE in COMPACTION#6407
Open
kokila-19 wants to merge 1 commit intoapache:masterfrom
Open
HIVE-29546: Iceberg: [V3] Support of ROW LINEAGE in COMPACTION#6407kokila-19 wants to merge 1 commit intoapache:masterfrom
kokila-19 wants to merge 1 commit intoapache:masterfrom
Conversation
kokila-19
force-pushed
the
row_lineage_comp
branch
from
ddcb497 to
305c54e
Compare
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
kokila-19
force-pushed
the
row_lineage_comp
branch
from
305c54e to
5859f42
Compare
asf-ci-hive
added
tests pending
tests failed
and removed
tests passed
tests pending
labels
kokila-19
force-pushed
the
row_lineage_comp
branch
2 times, most recently
from
051059e to
a01c6a1
Compare
asf-ci-hive
added
tests pending
tests unstable
and removed
tests failed
tests pending
labels
kokila-19
force-pushed
the
row_lineage_comp
branch
from
a01c6a1 to
ec71086
Compare
|
kokila-19
changed the title
ayushtkn
reviewed
Apr 8, 2026
Comment on lines
+102
to
+121
| private static void setRowLineageConfFlag(Configuration conf, boolean enabled) { | ||
| if (enabled) { | ||
| conf.setBoolean(SessionStateUtil.ROW_LINEAGE, true); | ||
| } else { | ||
| conf.unset(SessionStateUtil.ROW_LINEAGE); | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Enable the row lineage session flag for the current statement execution. | ||
| * Returns {@code true} if the flag was enabled | ||
| */ | ||
| public static void enableRowLineage(SessionState sessionState) { | ||
| setRowLineageConfFlag(sessionState.getConf(), true); | ||
| } | ||
|
|
||
| public static void disableRowLineage(SessionState sessionState) { | ||
| setRowLineageConfFlag(sessionState.getConf(), false); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
why can't we directly do
public static void enableRowLineage(SessionState sessionState) {
sessionState.getConf().setBoolean(SessionStateUtil.ROW_LINEAGE, true);
}
public static void disableRowLineage(SessionState sessionState) {
sessionState.getConf().setBoolean(SessionStateUtil.ROW_LINEAGE, false);
}
You have javadoc for one & not for others, considering it is a util class we can drop it
Comment on lines
+202
to
+206
| private static String buildSelectColumnList(Table icebergTable, HiveConf conf) { | ||
| return icebergTable.schema().columns().stream() | ||
| .map(Types.NestedField::name) | ||
| .map(col -> HiveUtils.unparseIdentifier(col, conf)) | ||
| .collect(Collectors.joining(", ")); |
Member
There was a problem hiding this comment.
I don't think this logic should kick in like this. If rowLineage isn't enabled, it should just return *, like before.
If rowLineage is enabled add the name from ROW_LINEAGE_COLUMNS_TO_FILE_NAME
Comment on lines
+89
to
+92
| public static String getRowLineageSelectColumns(boolean rowLineageEnabled) { | ||
| return rowLineageEnabled | ||
| ? ", " + VirtualColumn.ROW_LINEAGE_ID.getName() + ", " + VirtualColumn.LAST_UPDATED_SEQUENCE_NUMBER.getName() | ||
| : ""; |
Member
There was a problem hiding this comment.
Can you change it getRowLineageColumnsForCompaction
Comment on lines
+80
to
+83
| if (rowLineageEnabled) { | ||
| RowLineageUtils.enableRowLineage(sessionState); | ||
| LOG.debug("Row lineage flag set for compaction of table {}", compactTableName); | ||
| } |
Member
There was a problem hiding this comment.
can we not do it when we add the columns for row lineage, would avoid redundant checking rowLineageEnabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Preserve Iceberg v3 row lineage during compaction by generating compaction rewrite queries that carry row-lineage values correctly.
Propagate the row-lineage flag reliably into write job properties using RowLineageUtils.isRowLineageInsert(conf).
Why are the changes needed?
Compaction is implemented as INSERT OVERWRITE, without special handling it can rewrite data with new row-lineage values.
Does this PR introduce any user-facing change?
No, this PR does not introduce any user-facing changes. It adds internal support for row lineage during compaction.
How was this patch tested?
qtest