Skip to content

fix(go): correct Permissions serialization and add unit tests #3015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hubcio merged 9 commits into from
Mar 30, 2026
Merged

fix(go): correct Permissions serialization and add unit tests #3015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
26730f0
fix(go): fix command serialization bugs
saie-ch Mar 23, 2026
57d356f
fix(go): remove redundant nil checks for lint
saie-ch Mar 23, 2026
cf9f508
scope PR to Permissions fix only, add tests
saie-ch Mar 23, 2026
1764aa2
fix(go): format test file
saie-ch Mar 23, 2026
231c531
fix(go): address staticcheck lint issue
saie-ch Mar 24, 2026
343bff9
test(go): enhance Permissions test to verify all encoded values
saie-ch Mar 24, 2026
e6add02
test(go): add individual field tests and use asymmetric values for Pe…
saie-ch Mar 26, 2026
0fe9765
fix(go): correct gofmt alignment in test file
saie-ch Mar 26, 2026
d6e2146
Merge branch 'master' into go_issues
hubcio Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions foreign/go/contracts/users.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,12 @@ func (p *Permissions) MarshalBinary() ([]byte, error) {

position := 10

if p.Streams != nil {
if len(p.Streams) > 0 {
bytes[position] = byte(1)
position += 1

streamsCount := len(p.Streams)
currentStream := 1
for streamID, stream := range p.Streams {
binary.LittleEndian.PutUint32(bytes[position:position+4], uint32(streamID))
position += 4
Expand All @@ -76,10 +78,12 @@ func (p *Permissions) MarshalBinary() ([]byte, error) {
bytes[position+5] = boolToByte(stream.SendMessages)
position += 6

if stream.Topics != nil {
if len(stream.Topics) > 0 {
bytes[position] = byte(1)
position += 1

topicsCount := len(stream.Topics)
currentTopic := 1
for topicID, topic := range stream.Topics {
binary.LittleEndian.PutUint32(bytes[position:position+4], uint32(topicID))
position += 4
Expand All @@ -90,16 +94,29 @@ func (p *Permissions) MarshalBinary() ([]byte, error) {
bytes[position+3] = boolToByte(topic.SendMessages)
position += 4

bytes[position] = byte(0)
if currentTopic < topicsCount {
currentTopic++
bytes[position] = byte(1)
} else {
bytes[position] = byte(0)
}
position += 1
}
} else {
bytes[position] = byte(0)
position += 1
}

if currentStream < streamsCount {
currentStream++
bytes[position] = byte(1)
} else {
bytes[position] = byte(0)
}
position += 1
}
} else {
bytes[0] = byte(0)
bytes[position] = byte(0)
}

return bytes, nil
Expand Down
Loading
Loading