Add maxValueCount to DocValuesSkipper metadata#15993
Open
iprithv wants to merge 1 commit intoapache:mainfrom
Open
Add maxValueCount to DocValuesSkipper metadata#15993iprithv wants to merge 1 commit intoapache:mainfrom
iprithv wants to merge 1 commit intoapache:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
resolves #15794
DocValuesSkipper#maxValueCount()so consumers can determine whether a doc values field is definitely single-valued without unwrapping iterators.maxValueCountmetadata in Lucene90 doc values skipper metadata for new segments.Compatibility
Older Lucene90 segments do not have this metadata, so
maxValueCount()returns a safe upper bound:0for empty fields andInteger.MAX_VALUEotherwise. Exact values become available once segments are rewritten or merged with the new format.