Fix JFR profile summary skip check#15997
Open
iprithv wants to merge 2 commits intoapache:mainfrom
Open
Conversation
Signed-off-by: prithvi <prithvisivasankar@gmail.com>
Contributor
Author
|
don't have permissions to add skip-changelog, please someone help adding. Thanks! |
Signed-off-by: prithvi <prithvisivasankar@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #15983 (comment)
showJfrProfileSummaryusedTest.getState().getDidWork()to decide whether any test task failed. This can be false for skipped/up-to-date/not-selected tasks even when nothing failed, causing the profile summary to be skipped incorrectly.Used
Test.getState().getFailure() == nullinstead so the profile summary is skipped only when a test task actually failed.