chore(ai-tutors): regenerate lesson-08 knowledge base - #1050
Merged
Conversation
`inject-knowledge-base.py --check` reported `lesson-08-eval-driven-development.md` as out of date on `main`. The tutor prompt embeds its source page verbatim, and that page moved on without the prompt being rebuilt: apache#985 replaced worked example 2 with the real case-7 fixture — a `BashOperator` `KeyError` report carrying a `SYSTEM:` injection — where the prompt still described a dark-mode feature request with a different injection string. A tutor teaching prompt-injection defence from an example that no longer exists in the fixtures is the wrong thing to hand a learner. Pure `python3 ai-tutors/inject-knowledge-base.py` output; no hand edits. Nothing in the diff is fence-related — this drift predates the nested-fence work in apache#1010 / apache#1011 and is independent of it, which is why it was deliberately left out of apache#1010 rather than bundled in. `--check` is now clean across all eleven prompts. Generated-by: Claude Code (Opus 5)
4 tasks
potiuk
pushed a commit
that referenced
this pull request
Aug 17, 2026
#1080) The AI-tutor prompts under `ai-tutors/` are generated from `docs/education/` sources, but nothing enforced that they stayed in sync — a source page could change and the tutor prompt drift quietly. Add a local prek hook running `inject-knowledge-base.py --check`, which prints the stale prompts and exits non-zero; the contributor reruns the script without the flag to regenerate. `pass_filenames: false` because the script always scans every lesson — the `files:` filter gates whether the check fires, not what it inspects — and it always runs under `prek run --all-files` in CI. The hook immediately proved its worth: it caught `ai-tutors/lesson-08-eval-driven-development.md` as stale, fixed separately in #1050, which is merged first so this lands green. Closes #1051
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inject-knowledge-base.py --checkreportedai-tutors/lesson-08-eval-driven-development.mdas out of date onmain. This is the regeneration;--checkis now clean across all eleven prompts.case-7fixture — aBashOperatorKeyErrorreport whose body opens with aSYSTEM:injection. The prompt still described a dark-mode feature request carrying a different injection string. A tutor teaching prompt-injection defence from an example that no longer exists in the fixtures is the wrong thing to hand a learner.lesson-04andlesson-08were already stale onmainbefore that work, so this is independent drift and was deliberately kept out of fix(ai-tutors): handle nested code fences #1010 rather than bundled in.Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md) — generated tutor promptprojects/_template/)prek, workflows, validators)python3 ai-tutors/inject-knowledge-base.pyoutput, no hand editsTest plan
prek runpasses on the changed file (markdownlint, lychee, typos, SPDX, doctoc)python3 ai-tutors/inject-knowledge-base.py --checkexits clean — before this change it listedlesson-08tag_bare_code_fencesfixRFC-AI-0004 compliance
(None apply — regenerated documentation content.)
Linked issues
Refs #985 (the source-page change this propagates). Follow-up to #1010, which closed the related
lesson-04drift.Notes for reviewers (optional)
The whole diff is generator output, so the useful review question is whether the generator should have been run, not whether the text is right. Two things worth knowing:
inject-knowledge-base.py --check, so a source-page edit can silently leave a tutor prompt stale — which is exactly how this one drifted. Now thatai-tutors/is a uv workspace member (added in fix(ai-tutors): stop nested code fences inverting the fence state #1011), a--checkstep would be cheap to wire in. Worth a follow-up issue rather than folding into this PR.lesson-04before two source-page changes landed, so merging it would have rolled that file backwards. This PR is the remaining half of the same cleanup.