feat: Add batch float32 zero-copy angle encoding in qdp-core#1268
Open
viiccwen wants to merge 5 commits intoapache:mainfrom
Open
feat: Add batch float32 zero-copy angle encoding in qdp-core#1268viiccwen wants to merge 5 commits intoapache:mainfrom
viiccwen wants to merge 5 commits intoapache:mainfrom
Conversation
9 tasks
a5286e0 to
00ff260
Compare
rich7420
approved these changes
Apr 20, 2026
| /// Encode an angle batch from an existing GPU pointer (float32 input only). | ||
| /// | ||
| /// Zero-copy batch encoding from CUDA float32 tensors. Uses the default CUDA stream. | ||
| /// For stream interop use `encode_angle_batch_from_gpu_ptr_f32_with_stream`. |
Contributor
There was a problem hiding this comment.
nit: doc should mention that output precision follows the engine's configured precision, not necessarily f32 — F64 engine + F32 input yields complex128. Don't want downstream folks tripping on the DLPack dtype.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
Changes
qdp-kernelsFFIqdp-coreWhy
QDP already had angle float32 zero-copy support for single samples, but not for batched angle features. That made batched angle workloads inconsistent with the existing single-sample API and with the amplitude float32 batch implementation pattern.
This change closes that gap in the Rust/CUDA core only. Python bindings remain out of scope for a follow-up PR.
How
launch_angle_encode_batch_f32inqdp-kernels/src/angle.cuqdp-kernels/src/lib.rsAngleEncoderwith host-side batch float32 encoding and batch GPU-pointer float32 encodingQdpEngineentry points for angle batch float32 zero-copy on the default stream and explicit streamsChecklist