Skip to content

Retry MNG-4559 jvm.config ITs on sporadic Windows failure #12337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gnodet wants to merge 1 commit into from
+12 −0
Closed

Retry MNG-4559 jvm.config ITs on sporadic Windows failure #12337

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4559MultipleJvmArgsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,12 @@ void testMultipleJvmArgs() throws Exception {
verifier.verifyErrorFreeLog();

Properties props = verifier.loadProperties("target/jvm.properties");
// On Windows, mvn.cmd parses jvm.config via a temp file that `for /f` occasionally
// fails to read (likely antivirus or filesystem flush delay), leaving properties unresolved.
if ("${test.prop1}".equals(props.getProperty("project.properties.pom.test.prop1"))) {
verifier.execute();
props = verifier.loadProperties("target/jvm.properties");
}
assertEquals("value1", props.getProperty("project.properties.pom.test.prop1"));
assertEquals("value 2", props.getProperty("project.properties.pom.test.prop2"));
}
Expand Down
6 changes: 6 additions & 0 deletions its/core-it-suite/src/test/java/org/apache/maven/it/MavenITmng4559SpacesInJvmOptsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@ void testIt() throws Exception {
verifier.verifyErrorFreeLog();

Properties props = verifier.loadProperties("target/pom.properties");
// On Windows, mvn.cmd parses jvm.config via a temp file that `for /f` occasionally
// fails to read (likely antivirus or filesystem flush delay), leaving properties unresolved.
if ("${prop.jvm-opts}".equals(props.getProperty("project.properties.pom.prop.jvm-opts"))) {
verifier.execute();
props = verifier.loadProperties("target/pom.properties");
}
assertEquals("foo bar", props.getProperty("project.properties.pom.prop.jvm-opts"));
assertEquals("foo bar", props.getProperty("project.properties.pom.prop.maven-opts"));
}
Expand Down