Skip to content

Switch to uv - converters/goodata#216

Open
MonkeyCanCode wants to merge 2 commits into
apache:mainfrom
MonkeyCanCode:switch_to_uv_gooddata
Open

Switch to uv - converters/goodata#216
MonkeyCanCode wants to merge 2 commits into
apache:mainfrom
MonkeyCanCode:switch_to_uv_gooddata

Conversation

@MonkeyCanCode

@MonkeyCanCode MonkeyCanCode commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

As per ML, we want to proceed with more standard layout for python project by using uv. Here are the changes made in this PR:

  1. Added LICENSE and NOTICE (see above for reference)
  2. Updated README.md with instructions around uv
  3. Updated pyproject.toml with PEP 639
  4. Added pyproject.toml (unlike keywords in python/, this one has an extra entry for Snowflake)
  5. Removed pythonpath = ["src"] as that is default path
  6. Sorted the sections in pyproject.toml alphabetically
  7. Changed authors to ASF

Sample validation:

➜  gooddata git:(switch_to_uv_gooddata) ✗ uv sync
Resolved 11 packages in 3ms
      Built apache-ossie-gooddata @ file:///Users/yong/Desktop/GitHome/ossie/converters/gooddata
Prepared 1 package in 243ms
Uninstalled 1 package in 0.81ms
Installed 1 package in 1ms
 ~ apache-ossie-gooddata==0.2.0.dev0 (from file:///Users/yong/Desktop/GitHome/ossie/converters/gooddata)
➜  gooddata git:(switch_to_uv_gooddata) ✗ uv run pytest
==================================================================================================================================================== test session starts =====================================================================================================================================================
platform darwin -- Python 3.13.0, pytest-9.0.3, pluggy-1.6.0
rootdir: /Users/yong/Desktop/GitHome/ossie/converters/gooddata
configfile: pyproject.toml
testpaths: tests
plugins: cov-7.1.0
collected 28 items

tests/test_gooddata_to_osi.py ...........                                                                                                                                                                                                                                                                              [ 39%]
tests/test_models.py ..                                                                                                                                                                                                                                                                                                [ 46%]
tests/test_osi_to_gooddata.py ..........                                                                                                                                                                                                                                                                               [ 82%]
tests/test_roundtrip.py .....                                                                                                                                                                                                                                                                                          [100%]

===================================================================================================================================================== 28 passed in 0.10s =====================================================================================================================================================

@willpugh willpugh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a LICENSE and NOTICE for each connector, even though, they are all in the Ossie project?

Doesn't the project level one cover them?

@jbonofre

Copy link
Copy Markdown
Member

@willpugh the LICENSE and NOTICE at root level applies to the project from a source distribution perspective. If "modules" (like connector or converter) plan to include binary distribution in release, they might need specific LICENSE and NOTICE. Today, the "root" LICENSE and NOTICE are good enough (I will send a message on the dev@ mailing list about the first release).

@jbonofre jbonofre left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please remove the LICENSE and NOTICE file for now? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants