feat(plc4go): name every timeout via utils.WithNamedTimeout - #2688
Merged
Conversation
context.DeadlineExceeded is a metadata-free singleton: a bare "context deadline exceeded" never says which of the stacked deadlines fired or what its value was, making field timeouts undiagnosable. utils.WithNamedTimeout wraps context.WithTimeoutCause with a cause that reads "<name> <duration> exceeded" AND wraps the sentinel, so context.Cause carries the diagnosis while errors.Is(err, context.DeadlineExceeded) keeps working for every consumer (net/http propagates the cause in place of the sentinel since Go 1.23). All 16 bare context.WithTimeout call sites are converted with descriptive names (transaction completion timeout, segment ack wait timeout, MMI read timeout, connection close timeout, ...).
chrisdutz
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context.DeadlineExceeded is a metadata-free singleton: a bare "context deadline exceeded" never says which of the stacked deadlines fired or what its value was, making field timeouts undiagnosable.
utils.WithNamedTimeout wraps context.WithTimeoutCause with a cause that reads " exceeded" AND wraps the sentinel, so context.Cause carries the diagnosis while errors.Is(err, context.DeadlineExceeded) keeps working for every consumer (net/http propagates the cause in place of the sentinel since Go 1.23).
All 16 bare context.WithTimeout call sites are converted with descriptive names (transaction completion timeout, segment ack wait timeout, MMI read timeout, connection close timeout, ...).