Fix race conditions in ConnectionPool and SubProducer causing ThreadPool starvation - #292
Merged
blankensteiner merged 3 commits intoAug 11, 2026
Conversation
eugene-polozhenkov
force-pushed
the
fix/connection-pool-race-conditions
branch
from
August 10, 2026 18:13
867b9e8 to
0a8dc86
Compare
Contributor
|
Very nice, thanks! :-) |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #291
Changes
SubProducer.EstablishNewChannelThe
Task.Runlambda captured_dispatcherCtsand_channelfields rather than local values. Under thread pool saturation a concurrentEstablishNewChannelcall could dispose_dispatcherCtsbefore the lambda read.Token, causingObjectDisposedException-> fatal producer fault -> recreation death spiral.Fix: materialize
token = cts.Tokenand pinchannelto locals beforeTask.Run.ConnectionPool.GetConnectionNo serialization on connection establishment: all N producers missing the cache simultaneously called
EstablishNewConnectionin parallel, spawning N(producers) TCP connections and background tasks.Fix:
SemaphoreSlim(1,1)gate perPulsarUrlwith double-checked locking.ConnectionPool.DisposeConnectionTryRemove(key)removed whichever connection was at the key, not specifically the dead one. Under load theContinueWithdelay could cause it to evict a freshly established replacement.Fix:
TryRemove(KeyValuePair<K,V>)/ICollection.Remove(kvp)for atomickey+value comparison, with
#if NETSTANDARD2_0 || NETSTANDARD2_1following the existing library pattern.Tests
SubProducerTests: unit test for the dispatcher field-capture raceConnectionPoolTests: integration tests verifying all producers share a singleconnection after simultaneous reconnect (asserted via broker admin stats)
IntegrationFixture:CreateAdminClient()moved here fromConsumerTestsSame test as for the #291 with 3 sequential brokers ungraceful restarts, no thread spikes and N of connections stays within expected range.
