Skip to content

Add unit tests for 6 more JDBC query DAOs#13808

Merged
wu-sheng merged 6 commits intoapache:masterfrom
currenjin:test/jdbc-query-dao-coverage-round3
Apr 9, 2026
Merged

Add unit tests for 6 more JDBC query DAOs#13808
wu-sheng merged 6 commits intoapache:masterfrom
currenjin:test/jdbc-query-dao-coverage-round3

Conversation

@currenjin
Copy link
Copy Markdown
Contributor

What's this PR about?

Continues improving JDBC storage plugin test coverage by adding unit tests for 6 more query DAOs.

With the previous rounds (#13800, #13802), DAO test coverage goes from 12/39 (31%) to 18/39 (46%). All query DAOs with buildSQL-style protected methods are now covered.

Tests

DAO Tests
JDBCAggregationQueryDAO TABLE_COLUMN + time bucket range, subquery with group by, ASC/DESC order, additional conditions
JDBCRecordsQueryDAO TABLE_COLUMN, entity_id + time_bucket range, ASC/DESC order with limit
JDBCHierarchyQueryDAO service relations (TABLE_COLUMN + limit), instance relations (bidirectional OR with parameter binding)
JDBCTagAutoCompleteQueryDAO query keys (distinct + tag type + limit), query values (tag key + tag type)
JDBCEBPFProfilingDataDAO TABLE_COLUMN, schedule ID IN clause, upload time range
JDBCEBPFProfilingScheduleDAO TABLE_COLUMN, task ID filter, WHERE clause structure

All 24 new test cases pass locally.

Which issue does this PR relate to?

N/A - test coverage improvement.

@wu-sheng wu-sheng added this to the 10.5.0 milestone Apr 9, 2026
@wu-sheng wu-sheng merged commit 073238c into apache:master Apr 9, 2026
417 of 420 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants