Skip to content

Doc: fix cache dir sync_max_write record name#13222

Closed
masaori335 wants to merge 1 commit into
apache:masterfrom
masaori335:doc-fix-cache-dir-sync-max-write
Closed

Doc: fix cache dir sync_max_write record name#13222
masaori335 wants to merge 1 commit into
apache:masterfrom
masaori335:doc-fix-cache-dir-sync-max-write

Conversation

@masaori335

Copy link
Copy Markdown
Contributor

The records.yaml docs listed proxy.config.cache.dir.sync_max_writes (plural), but the actual registered record is sync_max_write (singular).

{RECT_CONFIG, "proxy.config.cache.dir.sync_max_write", RECD_INT, "2097152", RECU_DYNAMIC, RR_NULL, RECC_NULL, nullptr, RECA_NULL}

The records.yaml docs listed proxy.config.cache.dir.sync_max_writes
(plural), but the actual registered record is sync_max_write (singular).
@masaori335 masaori335 added this to the 11.0.0 milestone Jun 2, 2026
@masaori335 masaori335 self-assigned this Jun 2, 2026
Copilot AI review requested due to automatic review settings June 2, 2026 06:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes the documented record name for cache directory sync write sizing to match the actual registered configuration record in ATS.

Changes:

  • Correct proxy.config.cache.dir.sync_max_writesproxy.config.cache.dir.sync_max_write in the records.yaml documentation.

@JosiahWI

JosiahWI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

[approve ci autest 2]

@bneradt bneradt left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My previous PR was just approved that fixes this, I believe:
#13177

Since that is now merged, I suppose we can close this.

@masaori335

Copy link
Copy Markdown
Contributor Author

@bneradt Oh, you already fixed it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants