fix(postgresql): parse PITR retention TTL as decimal - #3391
Draft
weicao wants to merge 2 commits into
Draft
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## easton/pg-pitr-retention-ttl-validation #3391 +/- ##
=======================================================================
Coverage 0.00% 0.00%
=======================================================================
Files 195 195
Lines 28267 28274 +7
=======================================================================
- Misses 28267 28274 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
weicao
marked this pull request as draft
August 17, 2026 03:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DP_TTL_SECONDSvalue explicitly as base 10 during PITR expiry cutoff arithmeticCandidate
easton/pg-pitr-retention-ttl-validation500684b7a6f07e86b16b5d59b1e4c3c6113dcbc2(PR fix(postgresql): validate PITR retention TTL #3390)cd5ef60fcweicaoPostgreSQL PR targetingmain: fix(postgresql): stop pgbouncer after setup failure #3331, excluded because it is the independent PgBouncer setup laneContract
kubeblocks-addon-docs/docs/addon-continuous-backup-pitr-chain-integrity-guide.md, pit 3: retention cleanup must keep the advertised recovery window aligned with repository artifactskubeblocks-addon-docs/docs/addon-api/09b-backup-extensions.md: Continuous/PITR time ranges and repository retention must remain explainable and testableTDD evidence
RED commit
1d5f0a29e:DP_TTL_SECONDS=0360010000 - 3600 = 64008080, because Bash parsed03600as octal1920GREEN exact head
cd5ef60fc:git diff --check: cleanRuntime boundary
This is source-level arithmetic and ShellSpec validation only. Runtime packaging, environment execution, cleanup, and formal acceptance counts remain Test-owned and are not claimed by this PR.