Skip to content

fix(postgresql): preserve PITR timeline history - #3402

Draft
weicao wants to merge 2 commits into
easton/pg-pitr-restore-object-filterfrom
easton/pg-pitr-restore-history-skip-waldump
Draft

fix(postgresql): preserve PITR timeline history#3402
weicao wants to merge 2 commits into
easton/pg-pitr-restore-object-filterfrom
easton/pg-pitr-restore-history-skip-waldump

Conversation

@weicao

@weicao weicao commented Aug 16, 2026

Copy link
Copy Markdown
Contributor

What

Pull PostgreSQL timeline-history archives for PITR, but bypass pg_waldump transaction inspection for those non-WAL files.

Why

Timeline-history files are required by recovery across timelines, but they are metadata, not WAL segments. The restore traversal pulled them and then treated pg_waldump rejection as a hard WAL-inspection failure, aborting preparation before handoff.

Tests

  • RED (70eecc321): Bash 3.2 focused ShellSpec, 17 examples / 1 failure / 2 failed assertions
  • GREEN: Bash 3.2 focused ShellSpec, 17 examples / 0 failures
  • GREEN: Bash 5.3 full PostgreSQL ShellSpec, 285 examples / 0 failures
  • ShellCheck error severity, Bash syntax, and git diff --check
  • helm lint addons/postgresql: 1 chart / 0 failures
  • helm template: 41 documents / 1,014,422 bytes

@weicao
weicao requested review from a team, ldming and leon-ape as code owners August 16, 2026 22:42
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (8b549e1) to head (30566f4).

Files with missing lines Patch % Lines
...ns/postgresql/scripts-ut-spec/pitr_restore_spec.sh 0.00% 9 Missing ⚠️
Additional details and impacted files
@@                         Coverage Diff                          @@
##           easton/pg-pitr-restore-object-filter   #3402   +/-   ##
====================================================================
  Coverage                                  0.00%   0.00%           
====================================================================
  Files                                       195     195           
  Lines                                     28380   28389    +9     
====================================================================
- Misses                                    28380   28389    +9     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weicao
weicao marked this pull request as draft August 17, 2026 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants