Skip to content

fix(postgresql): retain current PITR timeline history #3403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
weicao wants to merge 2 commits into
base: easton/pg-pitr-restore-history-skip-waldump
Choose a base branch
from
+11 −1
Draft

fix(postgresql): retain current PITR timeline history #3403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
960b4eb
test(postgresql): cover current PITR timeline history
Aug 16, 2026
27005b6
fix(postgresql): retain current PITR timeline history
Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion addons/postgresql/dataprotection/postgresql-fetch-wal-log.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function fetch-wal-log(){
if [[ ! $wal_name =~ ^[0-9A-F]{24}$ && ! $wal_name =~ ^[0-9A-F]{8}\.history$ ]]; then
continue
fi
if [[ $wal_name < $start_wal_name ]]; then
if [[ ! $wal_name =~ \.history$ && $wal_name < $start_wal_name ]]; then
continue
fi
if [[ $pitr != "true" && $file =~ ".history" ]]; then
Expand Down
10 changes: 10 additions & 0 deletions addons/postgresql/scripts-ut-spec/pitr_restore_spec.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,16 @@ EOF
The path "${tmpdir}/dest/00000002.history" should be exist
End

It "fetches current timeline history even when it sorts below the start WAL"
export DATASAFED_LIST_ROOT="20260816/"
export DATASAFED_LIST_DIR="00000002.history.zst
000000020000000000000001.zst"
When call fetch-wal-log "${tmpdir}/dest" "000000020000000000000001" "2026-01-01 00:00:00" true
The status should eq 0
The path "${tmpdir}/dest/00000002.history" should be exist
The result of function call_log should include "datasafed pull -d zstd 00000002.history.zst"
End

It "stops at the first WAL pull failure instead of crossing an archive gap"
export DATASAFED_LIST_ROOT="20260816/"
export DATASAFED_LIST_DIR="000000010000000000000002.zst
Expand Down
Loading