Skip to content

test(hugegraph): fail closed on empty distributed FQDNs - #3423

Merged
weicao merged 1 commit into
dev/hugegraph-release-1.0from
fix/hugegraph-empty-fqdn-fail-closed
Aug 19, 2026
Merged

test(hugegraph): fail closed on empty distributed FQDNs#3423
weicao merged 1 commit into
dev/hugegraph-release-1.0from
fix/hugegraph-empty-fqdn-fail-closed

Conversation

@weicao

@weicao weicao commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Child PR into dev/hugegraph-release-1.0.

PD, Store, and Server start scripts already refuse an empty or comma-only podFQDNs list. Add offline tests so a missing Raft peer list cannot be treated as count 0.

Test

bash addons/hugegraph/tests/start_pd_test.sh
bash addons/hugegraph/tests/start_store_test.sh
bash addons/hugegraph/tests/start_server_test.sh
bash addons/hugegraph/tests/contract_test.sh
HugeGraph addon offline contracts passed

Main PR: #3412

PD/Store/Server start must refuse empty or comma-only peer lists
instead of treating a missing Raft identity as count 0.
@weicao
weicao requested review from a team and leon-ape as code owners August 19, 2026 16:22
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 0.00%. Comparing base (c986b81) to head (64d4e89).

Additional details and impacted files
@@                    Coverage Diff                    @@
##           dev/hugegraph-release-1.0   #3423   +/-   ##
=========================================================
  Coverage                       0.00%   0.00%           
=========================================================
  Files                             69      69           
  Lines                           7275    7275           
=========================================================
  Misses                          7275    7275           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@weicao
weicao merged commit f4b75a1 into dev/hugegraph-release-1.0 Aug 19, 2026
7 checks passed
@weicao
weicao deleted the fix/hugegraph-empty-fqdn-fail-closed branch August 19, 2026 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants