Skip to content

feat: support non-blocking shard actions #10725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
leon-ape wants to merge 18 commits into
base: main
Choose a base branch
from
Open

feat: support non-blocking shard actions #10725

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
2b09d92
feat: support non-blocking shard actions
leon-ape Jul 30, 2026
be9ac57
fix: harden non-blocking shard action reconciliation
leon-ape Jul 30, 2026
14b1b57
fix: refine non-blocking shard action reconciliation
leon-ape Jul 31, 2026
518623f
fix: preserve shard action request ordering
leon-ape Jul 31, 2026
567680b
fix: validate non-blocking actions at API owners
leon-ape Aug 3, 2026
832d7c3
docs: simplify action execution mode descriptions
leon-ape Aug 3, 2026
7c10269
refactor: simplify sharding action target handling
leon-ape Aug 3, 2026
38d509c
fix: reject unavailable definitions during resolution
leon-ape Aug 3, 2026
0dde0b4
revert: defer definition availability validation
leon-ape Aug 3, 2026
77a528f
refactor: generalize pending non-blocking action status
leon-ape Aug 3, 2026
89577cd
refactor: localize non-blocking shard actions
leon-ape Aug 3, 2026
f11169d
fix: preserve non-blocking shard action ordering
leon-ape Aug 4, 2026
52d4f7e
fix: serialize reversed sharding intents
leon-ape Aug 4, 2026
09c200c
fix: preserve terminal sharding action errors
leon-ape Aug 4, 2026
3c1e30e
Merge remote-tracking branch 'origin/main' into support/nonblocking-s…
leon-ape Aug 6, 2026
441dbac
refactor: isolate non-blocking sharding handling
leon-ape Aug 11, 2026
631dd49
Merge remote-tracking branch 'origin/main' into support/nonblocking-s…
leon-ape Aug 11, 2026
27d98fa
Merge remote-tracking branch 'origin/main' into support/nonblocking-s…
leon-ape Aug 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions apis/apps/v1/componentdefinition_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1910,6 +1910,9 @@ type Action struct {
// suitable for long-running Actions, such as data migration, rebalancing, or
// draining, whose duration depends on data volume or runtime conditions.
//
// Non-blocking mode can be enabled only for Action fields that explicitly
// document support for it.
//
// This field cannot be updated.
//
// +kubebuilder:default=false
Expand Down
8 changes: 8 additions & 0 deletions apis/apps/v1/shardingdefinition_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,6 +195,10 @@ type ShardingLifecycleActions struct {
//
// - KB_ADD_SHARD_NAME: The name of the shard being added.
//
// This Action supports both blocking and non-blocking modes. KubeBlocks does
// not finish adding the shard until the Action has succeeded on every
// selected target shard and Pod.
//
// Note: This field is immutable once it has been set.
//
// +optional
Expand All @@ -206,6 +210,10 @@ type ShardingLifecycleActions struct {
//
// - KB_REMOVE_SHARD_NAME: The name of the shard being removed.
//
// This Action supports both blocking and non-blocking modes. KubeBlocks does
// not remove the shard until the Action has succeeded on every selected
// target shard and Pod.
//
// Note: This field is immutable once it has been set.
//
// +optional
Expand Down
6 changes: 6 additions & 0 deletions config/crd/bases/apps.kubeblocks.io_clusters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -653,6 +653,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -11904,6 +11907,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down
45 changes: 45 additions & 0 deletions config/crd/bases/apps.kubeblocks.io_componentdefinitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4093,6 +4093,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -4705,6 +4708,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -5155,6 +5161,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
periodSeconds:
Expand Down Expand Up @@ -5621,6 +5630,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -6070,6 +6082,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -6522,6 +6537,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -6976,6 +6994,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -7420,6 +7441,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -7864,6 +7888,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -8308,6 +8335,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -8754,6 +8784,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -9192,6 +9225,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -9679,6 +9715,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
periodSeconds:
Expand Down Expand Up @@ -10145,6 +10184,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -18313,6 +18355,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down
6 changes: 6 additions & 0 deletions config/crd/bases/apps.kubeblocks.io_components.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,6 +535,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -997,6 +1000,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down
12 changes: 12 additions & 0 deletions config/crd/bases/apps.kubeblocks.io_rollouts.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,6 +509,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -966,6 +969,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -3900,6 +3906,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -4357,6 +4366,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down
20 changes: 20 additions & 0 deletions config/crd/bases/apps.kubeblocks.io_shardingdefinitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -885,6 +888,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -996,6 +1002,10 @@ spec:

- KB_ADD_SHARD_NAME: The name of the shard being added.

This Action supports both blocking and non-blocking modes. KubeBlocks does
not finish adding the shard until the Action has succeeded on every
selected target shard and Pod.

Note: This field is immutable once it has been set.
properties:
exec:
Expand Down Expand Up @@ -1343,6 +1353,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -1454,6 +1467,10 @@ spec:

- KB_REMOVE_SHARD_NAME: The name of the shard being removed.

This Action supports both blocking and non-blocking modes. KubeBlocks does
not remove the shard until the Action has succeeded on every selected
target shard and Pod.

Note: This field is immutable once it has been set.
properties:
exec:
Expand Down Expand Up @@ -1801,6 +1818,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down
6 changes: 6 additions & 0 deletions config/crd/bases/apps.kubeblocks.io_sidecardefinitions.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -2359,6 +2362,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down
3 changes: 3 additions & 0 deletions config/crd/bases/parameters.kubeblocks.io_componentparameters.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -561,6 +561,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down
9 changes: 9 additions & 0 deletions config/crd/bases/workloads.kubeblocks.io_instances.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,6 +431,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -1880,6 +1883,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down Expand Up @@ -2316,6 +2322,9 @@ spec:
suitable for long-running Actions, such as data migration, rebalancing, or
draining, whose duration depends on data volume or runtime conditions.

Non-blocking mode can be enabled only for Action fields that explicitly
document support for it.

This field cannot be updated.
type: boolean
preCondition:
Expand Down
Loading
Loading