fix(dataprotection): terminate cluster restores through resource owners

[leon-ape]

Problem

Cluster or Component deletion is the restore cancellation signal. The target PVC deletion timestamp is not. Cancellation must preserve controller ownership: each controller deletes only the objects it created and removes only the finalizer it added.

Changes

Cluster restore protection

• add a restore-specific Cluster finalizer owned only by ClusterRestoreReconciler
• add it while Cluster restore is active or PVC-scoped DP resources remain
• retain protection for Restore=False while the live Cluster still carries initial-restore intent
• on Cluster deletion, observe cached Restore/PVC state and wait for resource owners to finish cleanup
• treat every internal Restore, including Completed and Failed objects, as pending cleanup while Cluster deletion is in progress
• never delete Restore/helper PVC objects or patch target PVC finalizers from ClusterRestoreReconciler

VolumePopulator termination

• treat Cluster deletion as Cluster-wide cancellation and Component deletion as Component-scoped cancellation
• ignore target PVC deletion as a business signal
• delete VP-owned execution and postReady Restore objects, then wait for RestoreReconciler
• delete the VP-owned helper PVC and wait for disappearance
• finally remove only the VP-owned target PVC DP finalizer
• continue teardown for retained PVCs using identity recorded before restore resources are created
• verify exact UID/owner identity before every destructive operation

Restore creation ordering

• wait for the Cluster restore-protection finalizer before entering the PVC restore state machine
• before creating a postReady Restore, use the controller cache to confirm that the Cluster is not deleting and still carries restore protection
• stop postReady creation when the target Component is deleting
• use watches and normal requeue for dependency progression; no direct API reader is used as a correctness mechanism

Identity

• propagate Cluster UID through Cluster-owned VCT restore intent and VP-owned DP labels
• validate the live PVC → Instance/InstanceSet → Component → Cluster owner chain before restore starts
• record the verified Cluster and Component UID on a new target PVC before VP creates helper/Restore resources
• do not migrate or adopt resources from older controller versions in this deletion-focused PR

Ownership invariants

• ClusterRestoreReconciler only patches its Cluster restore-protection finalizer
• VolumePopulator never adds/removes the Cluster finalizer and never deletes target PVC/Component/Cluster
• RestoreReconciler remains the sole owner of Restore Job/Pod cleanup and Restore finalizers
• App/InstanceSet remains the sole deletion path for target PVCs

Dependencies

• fix(dataprotection): ignore target PVC deletion during restore #10819, fix(dataprotection): watch VolumePopulator restore dependencies #10825, and fix(workloads): aggregate restore status for instance API #10831 are merged into main
• this branch is synchronized with the latest main containing those changes

Tests

• full controllers/dataprotection package
• Cluster restore-intent UID injection/cleanup tests
• cmd/dataprotection compile test
• ownership, ordered termination, Retain owner detachment, failed/terminal Restore protection, target deletion neutrality, postReady creation guards, and UID mismatch coverage

Fixes #10755

[apecloud-bot]

Auto Cherry-pick Instructions

Usage:
  - /nopick: Not auto cherry-pick when PR merged.
  - /pick: release-x.x [release-x.x]: Auto cherry-pick to the specified branch when PR merged.

Example:
  - /nopick
  - /pick release-1.1

CLA Recheck Instructions

Usage:
  - /recheck-cla: Trigger a re-check of CLA status for this pull request.
Example:
  - /recheck-cla

[codecov]

Codecov Report

❌ Patch coverage is 75.79737% with 129 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.85%. Comparing base (63373ca) to head (9614838).

Files with missing lines	Patch %	Lines
...llers/dataprotection/volumepopulator_controller.go	73.01%	77 Missing and 35 partials ⚠️
...llers/dataprotection/cluster_restore_controller.go	85.21%	11 Missing and 6 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #10777      +/-   ##
==========================================
+ Coverage   65.76%   65.85%   +0.09%     
==========================================
  Files         510      511       +1     
  Lines       64958    65459     +501     
==========================================
+ Hits        42721    43111     +390     
- Misses      18449    18523      +74     
- Partials     3788     3825      +37     

Flag	Coverage Δ
unittests	65.85% <75.79%> (+0.09%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.