fix(dataprotection): validate restored PV provenance before completion - #10778
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10778 +/- ##
==========================================
+ Coverage 65.69% 65.84% +0.14%
==========================================
Files 510 510
Lines 64860 64958 +98
==========================================
+ Hits 42610 42769 +159
+ Misses 18462 18416 -46
+ Partials 3788 3773 -15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leon-ape
marked this pull request as ready for review
August 13, 2026 10:01
Remove the obsolete Populating-based external handler error suppression and use normal controller-runtime retries for API errors and optimistic-lock conflicts. Skip source validation for non-deleting bound terminal PVCs without changing postReady, unbound, or deletion paths. Cover retry and terminal boundaries with regression tests.
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 4 of 4 for #10755.
Problem
An already-bound target PVC was accepted as restore output without checking the target PV's claimRef or population-source annotation. Concurrent updates during the PV-to-PVC handoff could also overwrite a binding or leave the helper PV assigned to a target that uses another PV.
Changes
Scope
Changes are confined to VolumePopulator and its tests. Validation uses the controller's cached client and the existing populate-from annotation. The annotation is a source-name check, not a unique restore-attempt identity or a provisioner compatibility check.
Validation
controllers/dataprotectionsuite, including envtest.Fixes #10755