fix(dataprotection): wait for Kubernetes PVC binding before restore completion - #10779
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10779 +/- ##
==========================================
+ Coverage 64.85% 64.93% +0.08%
==========================================
Files 506 506
Lines 63316 63323 +7
==========================================
+ Hits 41062 41121 +59
+ Misses 18611 18572 -39
+ Partials 3643 3630 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leon-ape
marked this pull request as ready for review
August 13, 2026 10:01
leon-ape
marked this pull request as draft
August 13, 2026 14:26
leon-ape
marked this pull request as ready for review
August 14, 2026 02:32
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 14, 2026
leon-ape
marked this pull request as draft
August 14, 2026 02:37
leon-ape
marked this pull request as ready for review
August 14, 2026 02:42
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1 of 4 for #10755.
Problem
VolumePopulator used
spec.volumeName != ""as the restore-complete signal. That is weaker than the binding contract consumed by Kubernetes scheduling and can release restore resources before the PV controller has completed the binding.Changes
spec.volumeNameandpv.kubernetes.io/bind-completedbefore the first successful releaseRestore=Unknownwhile formal binding is pendingScope
This PR consumes the Kubernetes binding-complete signal. Restored-PV ClaimRef and populate-from provenance validation is intentionally isolated in #10778. This PR does not add provisioner compatibility handling, Cluster finalizers, cleanup-path refactoring, or change PVC status ownership.
Tests
controllers/dataprotectionsuite (156 Ginkgo specs plus unit tests)Fixes #10755