chore(dataprotection): leave PVC bound status to Kubernetes - #10780
Merged
Conversation
Collaborator
|
Auto Cherry-pick Instructions CLA Recheck Instructions |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #10780 +/- ##
==========================================
+ Coverage 64.85% 64.94% +0.09%
==========================================
Files 506 506
Lines 63316 63300 -16
==========================================
+ Hits 41062 41111 +49
+ Misses 18611 18564 -47
+ Partials 3643 3625 -18
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
leon-ape
changed the title
…c-pvc-bound-status # Conflicts: # controllers/dataprotection/volumepopulator_controller.go # controllers/dataprotection/volumepopulator_controller_test.go
Collaborator
Author
|
/approve |
apecloud-bot
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #10755.
Follow-up to #10337.
Problem
VolumePopulator mirrors a rebound PV into the target PVC status by setting
status.phase=Bound, capacity, and access modes. Kubernetes' PV controller already owns those status fields, and the scheduler's fully-bound contract is based onspec.volumeNamepluspv.kubernetes.io/bind-completed, not PVC phase.Keeping a second status writer duplicates the PV controller and can race with its status updates.
Changes
PopulatingandRestoreconditions unchangedScope
This PR does not change PV/PVC rebind behavior, helper cleanup, postReady behavior, or the binding-complete predicate introduced separately by #10779. Kubernetes remains responsible for converging the target PVC status after binding.
Tests
completeBoundPVCIfNeededlifecycle testscontrollers/dataprotectionsuite (156 Ginkgo specs plus unit tests)