Skip to content

feat(openapi): implement ResetInterface in OpenApiFactory #7922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
KevinMartinsDev wants to merge 2 commits into
base: main
Choose a base branch
from
+44 −1
Open

feat(openapi): implement ResetInterface in OpenApiFactory #7922

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
505c7a2
feat(openapi): implement ResetInterface in OpenApiFactory
KevinMartinsDev Apr 19, 2026
690d596
test(openapi): fix RouteCollection class not found in testReset
KevinMartinsDev Apr 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/OpenApi/Factory/OpenApiFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,11 +62,12 @@
use Symfony\Component\Routing\RouterInterface;
use Symfony\Component\TypeInfo\Type;
use Symfony\Component\TypeInfo\TypeIdentifier;
use Symfony\Contracts\Service\ResetInterface;

/**
* Generates an Open API v3 specification.
*/
final class OpenApiFactory implements OpenApiFactoryInterface
final class OpenApiFactory implements OpenApiFactoryInterface, ResetInterface
{
use NormalizeOperationNameTrait;
use StateOptionsTrait;
Expand Down Expand Up @@ -1065,4 +1066,10 @@ private function getErrorResource(string $error, ?int $status = null, ?string $d

return $this->localErrorResourceCache[$error] = $errorResource;
}

public function reset(): void
{
$this->routeCollection = null;
$this->localErrorResourceCache = [];
}
}
36 changes: 36 additions & 0 deletions src/OpenApi/Tests/Factory/OpenApiFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1438,4 +1438,40 @@ public function testGetExtensionPropertiesWithFalseValue(): void

$openApi = $factory->__invoke();
}

public function testReset(): void
{
$resourceNameCollectionFactory = $this->createMock(ResourceNameCollectionFactoryInterface::class);
$resourceCollectionMetadataFactory = $this->createMock(ResourceMetadataCollectionFactoryInterface::class);
$propertyNameCollectionFactory = $this->createMock(PropertyNameCollectionFactoryInterface::class);
$propertyMetadataFactory = $this->createMock(PropertyMetadataFactoryInterface::class);
$schemaFactory = $this->createMock(\ApiPlatform\JsonSchema\SchemaFactoryInterface::class);

$factory = new OpenApiFactory(
$resourceNameCollectionFactory,
$resourceCollectionMetadataFactory,
$propertyNameCollectionFactory,
$propertyMetadataFactory,
$schemaFactory
);

$refl = new \ReflectionClass($factory);
$routeCollection = $refl->getProperty('routeCollection');
$routeCollection->setAccessible(true);
if (class_exists(\Symfony\Component\Routing\RouteCollection::class)) {
$routeCollection->setValue($factory, $this->createMock(\Symfony\Component\Routing\RouteCollection::class));
}

$localErrorResourceCache = $refl->getProperty('localErrorResourceCache');
$localErrorResourceCache->setAccessible(true);
$localErrorResourceCache->setValue($factory, ['foo' => 'bar']);

$this->assertNotNull($routeCollection->getValue($factory));
$this->assertNotEmpty($localErrorResourceCache->getValue($factory));

$factory->reset();

$this->assertNull($routeCollection->getValue($factory));
$this->assertEmpty($localErrorResourceCache->getValue($factory));
}
}
Loading