Skip to content

chore: add missing browser param to redirect tests #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barjin merged 1 commit into from
Apr 13, 2026
Merged

chore: add missing browser param to redirect tests #433

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions impit-node/test/basics.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,7 @@ describe.each([
const proxyPort = (proxy.address() as AddressInfo)?.port;

const impit = new Impit({
browser,
proxyUrl: `http://user:@127.0.0.1:${proxyPort}`,
});

Expand Down Expand Up @@ -747,15 +748,15 @@ describe.each([
});

test('instance-level followRedirects: false disables redirects', async () => {
const noRedirect = new Impit({ followRedirects: false });
const noRedirect = new Impit({ browser, followRedirects: false });
const response = await noRedirect.fetch('http://localhost:3001/redirect/1');

expect(response.status).toBe(302);
expect(response.headers.get('location')).toBe('/get');
});

test('instance-level maxRedirects limits redirect chain', async () => {
const limited = new Impit({ maxRedirects: 1 });
const limited = new Impit({ browser, maxRedirects: 1 });

await expect(
limited.fetch('http://localhost:3001/redirect/2'),
Expand All @@ -778,7 +779,7 @@ describe.each([
});

test('per-request redirect: "follow" follows redirects', async () => {
const noRedirect = new Impit({ followRedirects: false });
const noRedirect = new Impit({ browser, followRedirects: false });
const response = await noRedirect.fetch('http://localhost:3001/redirect/1', {
redirect: 'follow',
});
Expand All @@ -804,7 +805,7 @@ describe.each([
});

test('bare Request does not override instance followRedirects: false', async () => {
const noRedirect = new Impit({ followRedirects: false });
const noRedirect = new Impit({ browser, followRedirects: false });
const request = new Request('http://localhost:3001/redirect/1');
const response = await noRedirect.fetch(request);

Expand All @@ -829,7 +830,7 @@ describe.each([
});

test('redirect: "follow" still respects instance maxRedirects', async () => {
const limited = new Impit({ followRedirects: false, maxRedirects: 1 });
const limited = new Impit({ browser, followRedirects: false, maxRedirects: 1 });

await expect(
limited.fetch('http://localhost:3001/redirect/2', { redirect: 'follow' }),
Expand Down