fall back to simple text output when stdout is not a tty#1392
fall back to simple text output when stdout is not a tty#1392knQzx wants to merge 2 commits intoapple:mainfrom
Conversation
|
@knQzx Thank you for the PR! Could you please add the commands you tested with, and before/after output, to the PR description? Would it be possible to add an integration test for this? |
|
added before/after output to the description and an integration test for this |
|
@knQzx It was a long time ago, but I think we made an implementation decision during initial progress bar development that if stderr wasn't a tty, we would suppress progress output, so that you'd only see warnings and errors. I can think of an idea or two, but why is this change to include progress with the warnings and errors useful for you? |
|
@jglogan mainly for ci logs - when a pull runs in a pipeline and stderr goes to a file, it's hard to tell if things are progressing or stuck. what were the ideas you had in mind? |
summary
fixes #113
test plan
before (main):
after:
also added
TestCLIProgressAutointegration test covering auto/plain/none modes