Move tool versions to Version Catalog#211
Merged
holzensp merged 1 commit intoapple:mainfrom Feb 21, 2024
Merged
Conversation
- fix: make version catalog accessible from `buildSrc` plugins - chore: declare `googleFormatVersion` in version catalog - chore: declare `ktfmt` in version catalog Relates-To: apple#204 Signed-off-by: Sam Gammon <sam@elide.ventures>
sgammon
force-pushed
the
chore/tools-in-catalog
branch
from
0b9e3ec to
8508af3
Compare
holzensp
approved these changes
Feb 21, 2024
Collaborator
holzensp
left a comment
holzensp
left a comment
There was a problem hiding this comment.
Much appreciated. CI green after manual restart (session timed out for the last run)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a fix to make Version Catalog symbols visible within the
buildSrcplugins, and then move tool versions (Google Java Format and ktfmt) into the catalog.Originally previewed as part of #204.
Changelog
buildSrcpluginsgoogleFormatVersionin version catalogktfmtin version catalog