InputMultispan and OutputMultispan + basic adoption in RigidArray and UniqueArray by Catfish-Man · Pull Request #579 · apple/swift-collections

Catfish-Man · 2026-02-24T01:12:54Z

This gets us the core "asynchronously create a unique/rigid array with a multi output span"

Sources/ContainersPreview/Types/OutputMultispan.swift

Co-authored-by: Guillaume Lessard <glessard@tffenterprises.com>

FranzBusch · 2026-02-24T09:56:58Z

Sources/BasicContainers/Multispans/OutputMultispan.swift

+@safe
+@frozen
+@available(SwiftStdlib 5.0, *)
+public struct OutputMultispan<Element: ~Copyable>: ~Copyable, ~Escapable {


Would be interesting to see if we could add a conversion method that vends you an io_vec from this safely

ooh that would be nice

Sources/BasicContainers/RigidArray/RigidArray+OutputMultispan.swift

…rently

Catfish-Man · 2026-03-13T20:51:38Z

I'll take a look at any CI failures, the tests pass locally so they're probably just forgetting to update one of the other build systems

Sources/ContainersPreview/Extensions/OutputMultispan+Extras.swift

Sources/BasicContainers/Multispans/InputMultispan.swift

jmschonfeld · 2026-03-13T22:32:25Z

Sources/BasicContainers/Multispans/InputMultispan.swift

+
+        // Shift elements after the subrange if necessary
+        let shiftDistance = addedCount
+        if shiftDistance != 0 && subrange.upperBound < count {


It looks like this code accounts for the possibility of multiple inline elements, but line 145 above assumes the presence of only a single inline element. Should they be made consistent?

I really want to generalize the rest of it to support multiple inline elements, but I haven't decided how practical that is. Picking one option definitely seems good though.

Sources/ContainersPreview/Types/InputMultispan.swift

Sources/ContainersPreview/Extensions/OutputMultispan+Extras.swift

Tests/ContainersTests/OutputMultispanTests.swift

FranzBusch · 2026-03-16T10:48:07Z

Sources/ContainersPreview/Types/InputMultispan.swift

+#endif
+
+@frozen @usableFromInline
+internal struct MultispanBuffer<Element: ~Copyable> {


NIT: Do you want to keep these shared internal types in this file our should we move them into a separate file?

I think if they grow any further functionality they should probably move, but for the moment I'm fine with leaving them there

Catfish-Man · 2026-03-18T23:49:06Z

Windows failures are a CI issue:

failed to connect to the docker API at npipe:////./pipe/docker_engine; check if the path is correct and if the daemon is running: open //./pipe/docker_engine: The system cannot find the file specified.

lorentey · 2026-03-23T21:41:05Z

The Windows failures are there to gently remind us that we exist to serve CI, not the other way around -- rerunning the failing jobs usually makes them pass. ¯\_(ツ)_/¯

@Lifetime

- Move the multispan types to the BasicContainers module, as they currently depend on UniqueArray - Underscore MultispanBuffer and SmallBufferPointerArray - @Lifetime → @_lifetime - Stop using @testable

lorentey · 2026-03-28T01:19:33Z

I added a commit to make the PR build in package form -- however, the tests are crashing right now.

Catfish-Man · 2026-03-30T23:44:26Z

This looks unrelated to my change…

~/swift-collections[leeloo-dallas-multispan]> swift build -Xswiftc -DCOLLECTIONS_UNSTABLE_CONTAINERS_PREVIEW
[1/1] Planning build
Building for debugging...
/Users/david/swift-collections/Sources/ContainersPreview/Protocols/Container/RangeReplaceableContainer.swift:398:13: error: lifetime-dependent variable 'items' escapes its scope
396 |   @inlinable
397 |   public mutating func append(
398 |     copying items: Span<Element>
    |             |- error: lifetime-dependent variable 'items' escapes its scope
    |             `- note: it depends on the lifetime of argument 'items'
399 |   ) {
400 |     guard !items.isEmpty else { return }
401 |     var items = items
    |                 `- note: this use causes the lifetime-dependent value to escape

Catfish-Man · 2026-03-30T23:53:42Z

aaaand trying to test locally crashes swift test

[229/242] Compiling _RopeModule Rope+MutatingForEach.swift
error: fatalError

Catfish-Man · 2026-04-01T00:22:46Z

Run xcrun swift --version
xcrun: error: missing DEVELOPER_DIR path: /Applications/Xcode_26.4.b2.app
Error: Process completed with exit code 1.

So helpful

shahmishal · 2026-04-02T23:05:35Z

@Catfish-Man You will need to rebase your change to pull in #615

Sources/ContainersPreview/Types/InputMultispan.swift

Sources/BasicContainers/RigidArray/RigidArray+OutputMultispan.swift

Catfish-Man · 2026-04-03T22:57:37Z

Android failure is

/home/runner/.config/swiftpm/swift-sdks/swift-DEVELOPMENT-SNAPSHOT-2026-04-01-a_android.artifactbundle/swift-android/swift-resources/usr/lib/swift-aarch64/clang/include/module.modulemap:10:8: error: redefinition of module '_Builtin_intrinsics'

Windows is

failed to connect to the docker API at npipe:////./pipe/docker_engine; check if the path is correct and if the daemon is running: open //./pipe/docker_engine: The system cannot find the file specified.

Linux hashed containers is

error: SwiftCompile normal x86_64 /__w/swift-collections/swift-collections/Sources/HashTreeCollections/HashNode/_AncestorHashSlots.swift failed with a nonzero exit code. Command line:     cd /__w/swift-collections
    builtin-SwiftPerFileCompile _AncestorHashSlots.swift

etc…

Linux containers is

error: SwiftCompile normal x86_64 /__w/swift-collections/swift-collections/Sources/HeapModule/Heap+Invariants.swift failed with a nonzero exit code. Command line:     cd /__w/swift-collections

etc…

WIP OutputMultispan + basic adoption in RigidArray and UniqueArray

c2944fb

glessard reviewed Feb 24, 2026

View reviewed changes

Sources/ContainersPreview/Types/OutputMultispan.swift Outdated Show resolved Hide resolved

glessard reviewed Feb 24, 2026

View reviewed changes

Sources/ContainersPreview/Types/OutputMultispan.swift Outdated Show resolved Hide resolved

Update Sources/ContainersPreview/Types/OutputMultispan.swift

146c2cd

Co-authored-by: Guillaume Lessard <glessard@tffenterprises.com>

FranzBusch reviewed Feb 24, 2026

View reviewed changes

Catfish-Man added 8 commits February 25, 2026 16:27

WIP InputMultispan

a9fc724

Fix a bunch of bugs in OutputMultispan

b7fe7ec

Add InputMultispan to the project file

fc4adec

Build fixes

03a4083

Many more fixes

97322b2

Review cleanup

b8992db

Add new files to cmake

e183879

Yet more fixes

81b2d37

Catfish-Man changed the title ~~WIP OutputMultispan + basic adoption in RigidArray and UniqueArray~~ WIP InputMultispan and OutputMultispan + basic adoption in RigidArray and UniqueArray Feb 26, 2026

lorentey reviewed Mar 3, 2026

View reviewed changes

Sources/BasicContainers/RigidArray/RigidArray+OutputMultispan.swift Show resolved Hide resolved

Catfish-Man added 5 commits March 2, 2026 16:33

Merge branch 'main' into leeloo-dallas-multispan

e97fd9a

Fix problems exposed by a newer swiftc

5ec9c1a

Preliminary tests for OutputMultispan. Note: several of them fail cur…

a0512f4

…rently

OutputMultispan tests pass now!

8a0506f

InputMultispan test fixes

df666c5

Catfish-Man changed the title ~~WIP InputMultispan and OutputMultispan + basic adoption in RigidArray and UniqueArray~~ InputMultispan and OutputMultispan + basic adoption in RigidArray and UniqueArray Mar 11, 2026

Catfish-Man added 5 commits March 11, 2026 14:03

Add tests to project, oops

31c8c74

Add inline storage support, but don't adopt it yet

5ad3a47

Adopt inline storage and deduplicate some logic

c422c75

Minor cleanup and inlining

d1dbe97

Address optimization TODOs

f61fabb

Catfish-Man marked this pull request as ready for review March 13, 2026 20:50

jmschonfeld reviewed Mar 13, 2026

View reviewed changes

Review fixes

db9f5f9

More review fixes

e6a68b2

Catfish-Man commented Mar 14, 2026

View reviewed changes

Sources/ContainersPreview/Extensions/OutputMultispan+Extras.swift Outdated Show resolved Hide resolved

FranzBusch reviewed Mar 16, 2026

View reviewed changes

Catfish-Man added 4 commits March 18, 2026 11:44

Remove stray logging in the tests

6350725

Merge remote-tracking branch 'github/main' into leeloo-dallas-multispan

0b76d6f

Update license headers for new files

a48b43a

Missed one

0d2d90f

Adjust things to make the package buildable

0e7016f

- Move the multispan types to the BasicContainers module, as they currently depend on UniqueArray - Underscore MultispanBuffer and SmallBufferPointerArray - @Lifetime → @_lifetime - Stop using @testable

Catfish-Man added 3 commits March 30, 2026 16:06

Switch from type punning to an enum

31aeffe

Fix compile errors and switch to @Lifetime()

6f73381

Switch back to _lifetime, I had misunderstood

64a5117

Catfish-Man added 2 commits March 31, 2026 16:24

Merge branch 'main' into leeloo-dallas-multispan

3599608

Fix build failures

7e21887

Fix test build failures

478d3ec

lorentey approved these changes Apr 3, 2026

View reviewed changes

Sources/ContainersPreview/Types/InputMultispan.swift Outdated Show resolved Hide resolved

Sources/BasicContainers/RigidArray/RigidArray+OutputMultispan.swift Show resolved Hide resolved

Sources/BasicContainers/RigidArray/RigidArray+OutputMultispan.swift Show resolved Hide resolved

Catfish-Man added 2 commits April 3, 2026 15:33

Merge remote-tracking branch 'github/main' into leeloo-dallas-multispan

6e45911

Resolve ambiguous methods

dd2b476

lorentey added this to the 1.4.2 milestone Apr 4, 2026

lorentey added 2 commits April 3, 2026 17:39

Merge remote-tracking branch 'origin/main' into leeloo-dallas-multispan

0006013

Oops, fix RawCollider conflict

2e1f550

lorentey force-pushed the leeloo-dallas-multispan branch from e9f8d83 to 2e1f550 Compare April 7, 2026 00:28

{Input,Output}Multispan: Fix bug in index validation

b387eba

Conversation

Catfish-Man commented Feb 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FranzBusch Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

Catfish-Man Feb 26, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Catfish-Man commented Mar 13, 2026

Uh oh!

Uh oh!

Uh oh!

jmschonfeld Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Catfish-Man Mar 13, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

FranzBusch Mar 16, 2026

Choose a reason for hiding this comment

Uh oh!

Catfish-Man Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

Catfish-Man commented Mar 18, 2026

Uh oh!

lorentey commented Mar 23, 2026

Uh oh!

lorentey commented Mar 28, 2026

Uh oh!

Catfish-Man commented Mar 30, 2026

Uh oh!

Catfish-Man commented Mar 30, 2026

Uh oh!

Catfish-Man commented Apr 1, 2026

Uh oh!

shahmishal commented Apr 2, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Catfish-Man commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Catfish-Man commented Feb 24, 2026 •

edited

Loading