fix(e2e): match explore DAO cards at their root after the gov-ui-kit 2.11.1 link overlay - #1364
Merged
Merged
Conversation
|
🚀 Preview Deployment: View Here |
|
E2E results (preview) Smoke
|
tyhonchik
force-pushed
the
fix/e2e-explore-dao-cards-locator
branch
from
September 4, 2026 15:20
22ee9b2 to
4bb6c8f
Compare
…2.11.1 link overlay Since gov-ui-kit 2.11.1 (APP-1089) a DataListItem with an href renders its link as an empty absolute overlay named via aria-labelledby, with the card content as a sibling of the link. The explore smoke tests located a card as a link that contains a heading, which no longer matches anything, failing two tests on every run since the 2.11.3 bump landed on main. The locator now matches the card root instead.
tyhonchik
force-pushed
the
fix/e2e-explore-dao-cards-locator
branch
from
September 4, 2026 15:23
4bb6c8f to
5845e96
Compare
milosh86
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two explore smoke tests (
displays a non-empty DAO list from the API,search filters the DAO list) fail on every run since #1358 landed on main. The bump to gov-ui-kit 2.11.3 brought in the 2.11.1 change toDataListItem(APP-1089, gov-ui-kit #765): a row with anhrefnow renders its link as an empty absolute overlay named viaaria-labelledby, and the card content is a sibling of the link instead of its child. The explore page helper located a DAO card as a link that contains a heading, which no longer matches anything. The app itself is fine, only the locator went stale.Changes
ExplorePage.daoCards()matches the card root.div:has(> a[aria-labelledby]):has(h2)insidemaininstead of a link filtered by a heading. Verified againstdev.app.aragon.org(main): the spec goes from 2 failed / 2 passed to 4 passed.Bisected on main runs:
c70fb6a3(#1361) 82 passed,c1cdcf91(#1358) 80 passed / 2 failed and every run after. The failure was visible in #1358's e2e comment but the e2e job itself is non-blocking, so it slipped through.🤖 Generated with Claude Code