[PATCH] fix: correct the list item types in transaction error data - #70
Open
guinux wants to merge 1 commit into
Open
[PATCH] fix: correct the list item types in transaction error data#70guinux wants to merge 1 commit into
guinux wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: correct the list item types in transaction error data
PrepareError::dataandCommitError::dataeach describe one of their lists with the wrong item type. In both cases the matchingDropimpl already frees the list with the right type.CommitData::FileConflictDeclared as
AlpmList<'a, &'a Conflict>, whilealpm_trans_commitreturns a list ofalpm_fileconflict_t(andDropfrees it asAlpmListMut<OwnedFileConflict>).PrepareData::PkgInvalidArchDeclared as
AlpmList<'a, &'h Package>, whileALPM_ERR_PKG_INVALID_ARCHproduces a list ofchar *package names (andDropfrees it asAlpmListMut<String>).PrepareData's'hparameter existed only for that variant, so with it corrected the enum drops toPrepareData<'a>.FileConflict::conflicting_targetIt reads the
targetfield rather thanctarget, so it returns the package that owns the incoming file rather than the package that already owns the conflicting one.