Skip to content

PE-9132: Fetch Turbo free allowance concurrently during upload prep #2169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vilenarios merged 1 commit into from
Jul 27, 2026
Merged

PE-9132: Fetch Turbo free allowance concurrently during upload prep #2169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions lib/core/upload/uploader.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,6 +369,12 @@ class UploadPaymentEvaluator {

TurboBalanceInterface turboBalance;

// Only needs the wallet, so start it now and let it run concurrently with
// the balance and cost round-trips below — it is awaited where the free
// status is computed. getFreeAllowance never throws (see its wrapper), so
// an in-flight future here cannot become an unhandled rejection.
final freeAllowanceFuture = getFreeAllowance();

turboBalance = await _getTurboBalance(canUseTurbo: _canUseTurbo);
final turboCostEstimate = await _turboUploadCostCalculator.calculateCost(
totalSize: dataItemSize,
Expand All @@ -392,7 +398,7 @@ class UploadPaymentEvaluator {
/// An item is free only if it is both small enough to qualify AND the
/// wallet still has free allowance to cover it. Size alone would promise
/// "free" to a user whose pool is used up, and then fail with a 402.
final freeAllowance = await getFreeAllowance();
final freeAllowance = await freeAllowanceFuture;
final freeStatus = freeUploadStatusFor(
isSizeEligible: dataItemSize <= allowedDataItemSizeForTurbo,
byteCount: dataItemSize,
Expand Down Expand Up @@ -429,6 +435,13 @@ class UploadPaymentEvaluator {

TurboBalanceInterface turboBalance;

// Only needs the wallet, so start it now and let it run concurrently with
// the balance, size and cost round-trips below — it is awaited where the
// free status is computed. getFreeAllowance never throws (see its
// wrapper), so an in-flight future here cannot become an unhandled
// rejection.
final freeAllowanceFuture = getFreeAllowance();

/// Check the balance of the user
/// If we can't get the balance, turbo won't be available
turboBalance = await _getTurboBalance(canUseTurbo: _canUseTurbo);
Expand Down Expand Up @@ -473,7 +486,7 @@ class UploadPaymentEvaluator {
arCostEstimate = UploadCostEstimate.zero();
}

final freeAllowance = await getFreeAllowance();
final freeAllowance = await freeAllowanceFuture;

/// Every item being small enough is not sufficient — the wallet's free
/// pool has to cover the whole upload too. When it does not, we report the
Expand Down
Loading