Skip to content

refactor(playwright): Improve overlay suppression, capture reliability - #3034

Open
swikstrom wants to merge 1 commit into
mainfrom
misc-playwright-enhancements
Open

refactor(playwright): Improve overlay suppression, capture reliability#3034
swikstrom wants to merge 1 commit into
mainfrom
misc-playwright-enhancements

Conversation

@swikstrom

@swikstrom swikstrom commented Aug 28, 2026

Copy link
Copy Markdown
Contributor

What This PR Changes

Summary

  • Refactored overlay/tooltip suppression to use CSS-only approach instead of DOM manipulation, preventing React state issues
  • Enhanced CSS selectors to support Radix UI, React Aria, and Sonner components in addition to existing toast libraries
  • Improved modal dismissal logic with better selector specificity and graceful fallbacks
  • Injected overlay suppression CSS at browser context startup for earlier and more consistent suppression
  • Added more statusbar element captures (terminal, status, notifications, network, agent-mode)
  • Improved emoji picker interaction with search input as primary method, with fallback to category navigation
  • Enhanced element waiting and timing strategies for better test reliability
  • Better positioning controls for highlight labels (fixedY, connectorMidX, alignVertical)

Changes

  • capture.js: Reset mouse/scroll at capture start, enhanced suppressToasts CSS selectors, simplified dismissToasts to use CSS-only suppression
  • app-lab.js: Improved modal dismissal, cleaned up app deletion flow with better selectors and waits, enhanced emoji selection, added retry logic for navigation, new statusbar captures
  • runner.js: Added initScript to browser context for early overlay suppression injection
  • Assets: Updated screenshots for stop button and sidebar icons, added new statusbar terminal screenshot

Contribution Guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant