docs: explicit when key is dynamic in services#104
Open
Sayrus wants to merge 1 commit intoargoproj:masterfrom
Open
docs: explicit when key is dynamic in services#104Sayrus wants to merge 1 commit intoargoproj:masterfrom
Sayrus wants to merge 1 commit intoargoproj:masterfrom
Conversation
Signed-off-by: Mathis Raguin <mathis@cri.epita.fr>
f5a2795 to
9fc466f
Compare
Codecov ReportBase: 49.21% // Head: 49.21% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #104 +/- ##
=======================================
Coverage 49.21% 49.21%
=======================================
Files 31 31
Lines 1855 1855
=======================================
Hits 913 913
Misses 743 743
Partials 199 199 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
10 tasks
Member
|
Hello Instead of changing the existing example, may I suggest you add a separate example that has multiple /spaces/channels/teams etc? This way instead of having a single example that readers are expected to take and then comment/uncomment stuff, they simply can take the example that matches their case directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It isn't clear to all users that
xxx- a map of the formkey: valuemeans that the user can specify their own key. This PR adds additional examples to help discern whether the key is statically defined by notifications-engine or defined by the end user.This follows questions asked on #argo-cd-notifications
I also reflected this in argoproj/argo-cd: argoproj/argo-cd#10589