Skip to content

Add pubsub service to notification engine#392

Open
KyriosGN0 wants to merge 11 commits intoargoproj:masterfrom
KyriosGN0:pubsub
Open

Add pubsub service to notification engine#392
KyriosGN0 wants to merge 11 commits intoargoproj:masterfrom
KyriosGN0:pubsub

Conversation

@KyriosGN0
Copy link
Copy Markdown

@KyriosGN0 KyriosGN0 commented Jul 24, 2025

This PR adds google pubusb service, similar to AWS SQS

should close #168

@KyriosGN0
Copy link
Copy Markdown
Author

KyriosGN0 commented Jul 24, 2025

Note: i didn't test this live, as there are no docs on how to do it, if there are any, i would gladly try them out
Tested locally to work

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 6, 2025

Codecov Report

❌ Patch coverage is 58.33333% with 25 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.13%. Comparing base (da04400) to head (4542518).
⚠️ Report is 28 commits behind head on master.

Files with missing lines Patch % Lines
pkg/services/pubsub.go 62.26% 17 Missing and 3 partials ⚠️
pkg/services/services.go 28.57% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #392      +/-   ##
==========================================
+ Coverage   55.41%   57.13%   +1.72%     
==========================================
  Files          46       49       +3     
  Lines        4125     3782     -343     
==========================================
- Hits         2286     2161     -125     
+ Misses       1511     1263     -248     
- Partials      328      358      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pasha-codefresh
Copy link
Copy Markdown
Member

@KyriosGN0 Could you fix conflicts? Also what docs you missing in order to test things?

@KyriosGN0
Copy link
Copy Markdown
Author

@pasha-codefresh my main issue is testing locally before i can merge this branch, the docs mention only after i merge this PR, but even then, i can't get argocd to run on my macos

@pasha-codefresh
Copy link
Copy Markdown
Member

Okay, I see, i will help you with testing

@KyriosGN0
Copy link
Copy Markdown
Author

Okay, I see, i will help you with testing

@pasha-codefresh will you test it yourself or would you help me set up argocd?

@KyriosGN0
Copy link
Copy Markdown
Author

hey @pasha-codefresh, have you had the chance to test this ?

@KyriosGN0
Copy link
Copy Markdown
Author

hey @pasha-codefresh, any updates? Thanks!

Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
Signed-off-by: AvivGuiser <avivguiser@gmail.com>
@KyriosGN0
Copy link
Copy Markdown
Author

@pasha-codefresh i ended up doing a successful test on my local machine, could you please review the PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pub/Sub service

2 participants