Skip to content

Add all supported number bases and single/double quotes strings - #3

Open
enricobolzonello wants to merge 2 commits into
arialang:masterfrom
enricobolzonello:number_bases
Open

Add all supported number bases and single/double quotes strings#3
enricobolzonello wants to merge 2 commits into
arialang:masterfrom
enricobolzonello:number_bases

Conversation

@enricobolzonello

Copy link
Copy Markdown
Contributor
  • Add binary (0b), octal (0o), and hexadecimal (0x) number literal support
  • Add single-quote string literal support
  • Add test coverage for all number base formats
  • Improve variable naming throughout

@ZocoLini ZocoLini left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something that also needs to be updated:

There is a couple of highlight queries in queries/highlight.csm:

[ "func"
  "return"
  "struct"
  "operator"
  "reverse"
  "type"] @keyword

(identifier) @variable
(string) @string
(number) @number
(comment) @comment

Because you renamed string and number this should no longer work. I would group all string literals under string and all the number literals under number

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants