Conversation
…g will break; related unique index, functional index, and CHECK constraint updated to use the new column name).
Contributor
|
|
||||||||||||||||
Comment on lines
+1
to
+2
| -- Modify "users" table | ||
| ALTER TABLE `users` DROP CHECK `users_chk_1`, ADD CONSTRAINT `users_chk_1` CHECK (regexp_like(`email`,_utf8mb4'^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,}$')), DROP COLUMN `email_address`, ADD COLUMN `email` varchar(255) NOT NULL COMMENT "Email address of the user, now stored case-insensitively" COLLATE utf8mb4_0900_as_ci AFTER `user_name`, DROP INDEX `user_name_email_address`, DROP INDEX `users_email_address_lower`, ADD UNIQUE INDEX `email` (`email`), ADD UNIQUE INDEX `user_name_email` (`user_name`, `email`), ADD INDEX `users_email_lower` ((lower(`email`))); |
Contributor
There was a problem hiding this comment.
Caution
destructive changes detected
Dropping non-virtual column "email_address" DS103
Add a pre-migration check to ensure column "email_address" is NULL before dropping it
Suggested change
| -- Modify "users" table | |
| ALTER TABLE `users` DROP CHECK `users_chk_1`, ADD CONSTRAINT `users_chk_1` CHECK (regexp_like(`email`,_utf8mb4'^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,}$')), DROP COLUMN `email_address`, ADD COLUMN `email` varchar(255) NOT NULL COMMENT "Email address of the user, now stored case-insensitively" COLLATE utf8mb4_0900_as_ci AFTER `user_name`, DROP INDEX `user_name_email_address`, DROP INDEX `users_email_address_lower`, ADD UNIQUE INDEX `email` (`email`), ADD UNIQUE INDEX `user_name_email` (`user_name`, `email`), ADD INDEX `users_email_lower` ((lower(`email`))); | |
| -- atlas:txtar | |
| -- checks/destructive.sql -- | |
| -- atlas:assert DS103 | |
| SELECT NOT EXISTS (SELECT 1 FROM `users` WHERE `email_address` IS NOT NULL) AS `is_empty`; | |
| -- migration.sql -- | |
| -- Modify "users" table | |
| ALTER TABLE `users` DROP CHECK `users_chk_1`, ADD CONSTRAINT `users_chk_1` CHECK (regexp_like(`email`,_utf8mb4'^[A-Za-z0-9._%+-]+@[A-Za-z0-9.-]+\\.[A-Za-z]{2,}$')), DROP COLUMN `email_address`, ADD COLUMN `email` varchar(255) NOT NULL COMMENT "Email address of the user, now stored case-insensitively" COLLATE utf8mb4_0900_as_ci AFTER `user_name`, DROP INDEX `user_name_email_address`, DROP INDEX `users_email_address_lower`, ADD UNIQUE INDEX `email` (`email`), ADD UNIQUE INDEX `user_name_email` (`user_name`, `email`), ADD INDEX `users_email_lower` ((lower(`email`))); |
Ensure to run atlas migrate hash --dir "file://dirs/ecommerce/migrations" after applying the suggested changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backward-incompatible change: renamed . to . (applications referencing will break; related unique index, functional index, and CHECK constraint updated to use the new column name).