Skip to content

client-lib: fee support in RedeemNote #935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
louisinger wants to merge 2 commits into
base: master
Choose a base branch
from
Open

client-lib: fee support in RedeemNote #935

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9ffbe74
support fee in RedeemNote
louisinger Feb 26, 2026
575d784
fix
louisinger Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 40 additions & 3 deletions pkg/client-lib/batch_session.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,16 @@ func (a *service) RedeemNotes(
return "", err
}

info, err := a.client.GetInfo(ctx)
if err != nil {
return "", err
}

feeEstimator, err := arkfee.New(info.Fees.IntentFees)
if err != nil {
return "", err
}

amount := uint64(0)

options := newDefaultSettleOptions()
Expand All @@ -88,7 +98,22 @@ func (a *service) RedeemNotes(
if err != nil {
return "", err
}
amount += uint64(v.Value)
fees, err := feeEstimator.EvalOffchainInput(arkfee.OffchainInput{
Amount: uint64(v.Value),
Type: arkfee.VtxoTypeNote,
})
if err != nil {
return "", err
}

feesSats := uint64(fees.ToSatoshis())
Copy link
Copy Markdown

@IsaqueFranklin IsaqueFranklin Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially, I was concerned about using uint64 here for the value, because the feeEstimator returns a float64 and it would just truncate the number down, which would mean that the fee would be less than what the operator needs and the redeem would not work. But I checked the ToSatoshis() method in pkg/ark-lib/arkfee/types.go and it already uses math.Ceil, which rounds the number up, so it's fine.

noteValue := uint64(v.Value)
if feesSats >= noteValue {
// not profitable to redeem this note
return "", fmt.Errorf("fees (%d) exceed note value (%d)", feesSats, noteValue)
}

amount += noteValue - feesSats
Comment thread
louisinger marked this conversation as resolved.
}

_, offchainAddrs, _, _, err := a.wallet.GetAddresses(ctx)
Expand All @@ -99,10 +124,22 @@ func (a *service) RedeemNotes(
return "", fmt.Errorf("no funds detected")
}

receiversOutput := []types.Receiver{{
receiver := types.Receiver{
To: offchainAddrs[0].Address,
Amount: amount,
}}
}
outputFees, err := feeEstimator.EvalOffchainOutput(receiver.ToArkFeeOutput())
if err != nil {
return "", err
}

outputFeesSats := uint64(outputFees.ToSatoshis())
if outputFeesSats > amount {
return "", fmt.Errorf("fees (%d) exceed amount (%d)", outputFeesSats, amount)
}

receiver.Amount = amount - outputFeesSats
receiversOutput := []types.Receiver{receiver}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

return a.joinBatchWithRetry(ctx, notes, receiversOutput, *options, nil, nil)
}
Expand Down
Loading