Skip to content

SignMessage rpc #954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bitcoin-coder-bob wants to merge 10 commits into
base: master
Choose a base branch
from
Open

SignMessage rpc #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cafe919
SignMessage rpc
bitcoin-coder-bob Mar 4, 2026
ebe18da
test updates removing uneeded items, add fixtures
bitcoin-coder-bob Mar 13, 2026
31e5b44
SignMessage: use string instead of bytes in proto
bitcoin-coder-bob Mar 13, 2026
db3e733
update proto and openapi.json to have comment for hex-encoded message…
bitcoin-coder-bob Mar 13, 2026
fa47e25
enforce in SignMessage hex string pattern/length in proto
bitcoin-coder-bob Mar 13, 2026
343a8ae
move test_keys out of fixtures and into test file directly
bitcoin-coder-bob Mar 16, 2026
d5c2963
check decoded signature is 64 bytes in SignMessage client
bitcoin-coder-bob Mar 16, 2026
49e2b82
ErrSignerDisabled usage
bitcoin-coder-bob Mar 17, 2026
8cd6478
Merge branch 'master' into bob/SignMessage
bitcoin-coder-bob Apr 2, 2026
611db19
Merge master into bob/SignMessage
bitcoin-coder-bob Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 64 additions & 0 deletions api-spec/openapi/swagger/signer/v1/service.openapi.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,46 @@
}
}
},
"/v1/sign-message": {
"post": {
"tags": [
"SignerService"
],
"operationId": "SignerService_SignMessage",
"requestBody": {
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/SignMessageRequest"
}
}
},
"required": true
},
"responses": {
"200": {
"description": "a successful response.",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/SignMessageResponse"
}
}
}
},
"default": {
"description": "An unexpected error response.",
"content": {
"application/json": {
"schema": {
"$ref": "#/components/schemas/Status"
}
}
}
}
}
}
},
"/v1/sign-transaction": {
"post": {
"tags": [
Expand Down Expand Up @@ -184,6 +224,30 @@
}
}
},
"SignMessageRequest": {
"title": "SignMessageRequest",
"type": "object",
"properties": {
"message": {
"pattern": "^(?:[0-9a-fA-F]{2})*$",
"type": "string",
"description": "hex-encoded message to sign"
}
}
},
"SignMessageResponse": {
"title": "SignMessageResponse",
"type": "object",
"properties": {
"signature": {
"pattern": "^[0-9a-fA-F]{128}$",
"maxLength": 128,
"minLength": 128,
"type": "string",
"description": "hex-encoded Schnorr signature"
}
}
},
Comment thread
coderabbitai[bot] marked this conversation as resolved.
"SignTransactionRequest": {
"title": "SignTransactionRequest",
"type": "object",
Expand Down
119 changes: 109 additions & 10 deletions api-spec/protobuf/gen/signer/v1/service.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

35 changes: 35 additions & 0 deletions api-spec/protobuf/gen/signer/v1/service.pb.rgw.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

38 changes: 38 additions & 0 deletions api-spec/protobuf/gen/signer/v1/service_grpc.pb.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading