Skip to content

Multi region support#26

Open
kadaan wants to merge 10 commits into
arkadiyt:masterfrom
kadaan:multi_region_support
Open

Multi region support#26
kadaan wants to merge 10 commits into
arkadiyt:masterfrom
kadaan:multi_region_support

Conversation

@kadaan

@kadaan kadaan commented Jan 31, 2019

Copy link
Copy Markdown
  • Display progress while running by specifying --progress
┌ [+] Probing APIGateway...
├── [+] ap-northeast-1
├── [+] ap-northeast-2
├── [+] ap-south-1
├── [+] ap-southeast-1
├── [+] ap-southeast-2
├── [+] ca-central-1
├── [+] eu-central-1
  • Include tag data in ec2 records by adding --include_tags name
  • Multi-region support. Defaults to the region specified by AWS_DEFAULT_REGION or AWS_REGION. Many regions can be specified. all will include all regions.

@coveralls

coveralls commented Jan 31, 2019

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 140

  • 149 of 154 (96.75%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.8%) to 98.246%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/aws_public_ips/utils.rb 33 38 86.84%
Totals Coverage Status
Change from base Build 136: -1.8%
Covered Lines: 280
Relevant Lines: 285

💛 - Coveralls

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 99

  • 119 of 151 (78.81%) changed or added relevant lines in 13 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-11.3%) to 88.652%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/aws_public_ips/cli.rb 8 11 72.73%
lib/aws_public_ips/cli_options.rb 38 46 82.61%
lib/aws_public_ips/utils.rb 17 38 44.74%
Totals Coverage Status
Change from base Build 97: -11.3%
Covered Lines: 250
Relevant Lines: 282

💛 - Coveralls

@kadaan

kadaan commented Jan 31, 2019

Copy link
Copy Markdown
Author

@arkadiyt Can I get some feedback?

@arkadiyt

arkadiyt commented Feb 1, 2019

Copy link
Copy Markdown
Owner

@kadaan thanks for the PR! I'll try to get to this tonight

@eamonnfaherty

Copy link
Copy Markdown
Contributor

What's happening with this? I would love to see this merged!

@kadaan

kadaan commented Mar 28, 2019

Copy link
Copy Markdown
Author

Me too :)

@arkadiyt arkadiyt added the enhancement New feature or request label Oct 22, 2019
@SmeegeSec

SmeegeSec commented Oct 22, 2019

Copy link
Copy Markdown

This PR is working great for me so far. The only small difference to get it working was needing to run gem install tty-spinner. Thanks arkadiyt and @kadaan for your work here.

@breser

breser commented Mar 10, 2020

Copy link
Copy Markdown

I've been using this PR for a while now. I've got a version that's based on the 1.0.7 version of master here: https://github.com/breser/aws_public_ips/tree/multi_region_support

@kiwiz

kiwiz commented May 14, 2020

Copy link
Copy Markdown

@kadaan Hiya, can I help with getting this PR merged?

@kadaan

kadaan commented May 15, 2020

Copy link
Copy Markdown
Author

@kiwiz Go for it!!!

@kiwiz

kiwiz commented May 18, 2020

Copy link
Copy Markdown

@kadaan Thanks for your blessing (and my bad, thought you were the maintainer)
@arkadiyt Hiya, what work is necessary to get this merged?

@mihaiplesa

Copy link
Copy Markdown

@arkadiyt let us know if we can help getting this in.

@weisslj

weisslj commented Apr 29, 2021

Copy link
Copy Markdown

@kadaan @arkadiyt Any help we can provide to get this merged? This is really useful for us!

@f-ivasic

f-ivasic commented Oct 4, 2023

Copy link
Copy Markdown

Pity this request is not merged, I'm using it for several months and it is so useful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants