Skip to content

fix(containers): allow patches/ in build context#11

Merged
arsac merged 1 commit intomainfrom
fix/subgen-pyav-dts-segfault
Apr 29, 2026
Merged

fix(containers): allow patches/ in build context#11
arsac merged 1 commit intomainfrom
fix/subgen-pyav-dts-segfault

Conversation

@arsac
Copy link
Copy Markdown
Owner

@arsac arsac commented Apr 29, 2026

Summary

PR #10 still failed CI with the same failed to calculate checksum: \"/patches/01-always-extract-audio-via-ffmpeg.patch\": not found error.

Root cause: `include/.dockerignore` is the shared template copied to every app's build dir, and it uses an allow-list (`/*` then `!defaults/`, `!scripts/`, `!entrypoint.sh`). Anything else — including `patches/` — gets excluded from the build context.

Changes

  • `include/.dockerignore`: add `!patches/` alongside the other sanctioned per-app dirs
  • `apps/subgen/Dockerfile`: revert to copying the whole `patches/` directory now that it's allowed

Test plan

  • CI build succeeds on this PR
  • Resulting image has `if audio_tracks:` at line 1520 of `/subgen/subgen.py`
  • Subgen runs without segfaulting on DTS files

🤖 Generated with Claude Code

The shared .dockerignore allow-list excluded patches/, so the
subgen build couldn't COPY its patch file. Adding patches/ alongside
defaults/ and scripts/ as a sanctioned per-app directory.

Also reverts the single-file COPY in apps/subgen back to the
directory form now that it works.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@arsac arsac merged commit 824a1a9 into main Apr 29, 2026
4 of 5 checks passed
@arsac arsac deleted the fix/subgen-pyav-dts-segfault branch April 29, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant