-
Notifications
You must be signed in to change notification settings - Fork 149
Add facet filters to accession browse page #2207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danloveg
wants to merge
11
commits into
artefactual:qa/2.x
Choose a base branch
from
danloveg:dev/issue-2159-add-facets-to-accession-browse
base: qa/2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
0b40033
Add $AGGS to accession browse
danloveg e4beb48
Use DefaultBrowseAction, implement populateAgg
danloveg 1187d39
Use query builder from DefaultBrowseAction
danloveg e79662c
Add facet filters in sidebar
danloveg bb35344
Set sort options in template
danloveg bfebd28
Fix subquery searching in search box
danloveg ab40569
Add donor and creator facets
danloveg 501230d
Use request params when exporting accessions
danloveg d966a90
Merge branch 'qa/2.x' into dev/issue-2159-add-facets-to-accession-browse
danloveg 0543829
Add missing bool parameter
danloveg e372ba4
Set boost values for accession
danloveg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see these weights being set anywhere and I don't think they'd be inherited from the browse action either. Doesn't removing them impact the search result order?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out, I didn't consider that.
I found that
addAdvancedSearchFilters()makes a call to thesetBoostValues()function, so I added boost values for the accession fields that were being boosted previously there. See here: e372ba4The ordering should be the same now that the fields are boosted properly.