Skip to content

Enable crunching with X-Crunch header and crunch entire response #1061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alloy merged 5 commits into from
May 30, 2018
+28 −7
Merged

Enable crunching with X-Crunch header and crunch entire response #1061

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8f04128
Enable crunching with X-Crunch header
just-be-dev May 28, 2018
d98c095
Crunch entire payload instead of only data
just-be-dev May 28, 2018
830492e
Update test to reflect whole payload crunch
just-be-dev May 28, 2018
fdfe13c
Add header to response if payload crunched
just-be-dev May 28, 2018
f7c35a1
Merge branch 'master' into add_crunch_header
alloy May 30, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 22 additions & 3 deletions src/lib/__tests__/crunchInterceptor.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,8 @@ describe("crunchInterceptor", () => {
.get("/?query={greeting}")
.set("Accept", "application/json")
.expect(200)
.then(() => {
.then(res => {
expect(res.headers).not.toHaveProperty("X-Crunch")
expect(intercept).not.toHaveBeenCalled()
})
})
Expand All @@ -27,8 +28,25 @@ describe("crunchInterceptor", () => {
.get("/?query={greeting}&crunch")
.set("Accept", "application/json")
.expect(200)
.expect("X-Crunch", "true")
.then(res => {
expect(res.body).toMatchObject(
crunch({ data: { greeting: "Hello World" } })
)
})
})

it("should crunch the result when header is present", () => {
return request(app(crunchInterceptor))
.get("/?query={greeting}")
.set("Accept", "application/json")
.set("X-Crunch", true)
.expect(200)
.expect("X-Crunch", "true")
.then(res => {
expect(res.body.data).toMatchObject(crunch({ greeting: "Hello World" }))
expect(res.body).toMatchObject(
crunch({ data: { greeting: "Hello World" } })
)
})
})

Expand All @@ -38,7 +56,8 @@ describe("crunchInterceptor", () => {
.get("/?query={greeting}&crunch")
.set("Accept", "application/json")
.expect(404)
.then(() => {
.then(res => {
expect(res.headers).not.toHaveProperty("X-Crunch")
expect(intercept).not.toHaveBeenCalled()
})
})
Expand Down
10 changes: 6 additions & 4 deletions src/lib/crunchInterceptor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,14 @@
import { crunch } from "graphql-crunch"
import interceptor from "express-interceptor"

export const interceptorCallback = req => ({
isInterceptable: () => req.query.hasOwnProperty("crunch"),
export const interceptorCallback = (req, res) => ({
isInterceptable: () =>
req.query.hasOwnProperty("crunch") || req.headers["x-crunch"],
intercept: (body, send) => {
body = JSON.parse(body) // eslint-disable-line no-param-reassign
if (body && body.data) {
body.data = crunch(body.data) // eslint-disable-line no-param-reassign
if (body) {
body = crunch(body) // eslint-disable-line no-param-reassign
res.set("X-Crunch", "true")
}
send(JSON.stringify(body))
},
Expand Down