fix(providers): fail closed when Anthropic parse realloc fails - #80
Draft
cursor[bot] wants to merge 1 commit into
Draft
fix(providers): fail closed when Anthropic parse realloc fails#80cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
parse_response_body doubled text_cap/tool_cap before realloc succeeded. On OOM, memcpy and tool_use indexing used the inflated cap against the live heap block. Only publish capacity after realloc and treat grow failure as a parse error. Co-authored-by: esadrianno <esadrianno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_response_bodypublishedtext_cap/tool_capbeforereallocsucceeded. When grow failed, latermemcpyandtool_calls[tool_count]still used the inflated cap against the live heap block.Bug
src/providers/anthropic.c(parse_response_body)contentwith a text block of 256+ bytes (or a 6thtool_use) whilereallocfails (memory pressure, cgroupMemoryMax). Call chain:agent_run→ provider router →anthropic_chat→do_request→parse_response_body.Root cause
Capacity was doubled, then
realloccould fail and leave the pointer on the old allocation. The text path still compared against the new cap and copied. The tool pathcontinued after a failed grow, so the nexttool_useskipped the grow check and wrote one slot past the array.Fix
realloc.Validation
CI=true make test_anthropic test_provider test_routertest_anthropic(including forced-realloc-failure cases)