test(title-sync): end-to-end guard for derived-name title clobbering (follow-up to #1545)#1574
Conversation
…rs the session title The nameSource="derived" rule from asheshgoplani#1545 is unit-tested at both links (derived name resolves to "", and an empty name is a reconcile no-op), but the composition itself was unpinned: a refactor that resolves the name inside ReconcileTitleFromClaude without going through ClaudeSessionName could reintroduce the folder-name clobbering with every existing test still green. Drive the real reconcile path against a seeded derived-name session file and assert the title survives.
|
Warning Review limit reached
Next review available in: 42 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Test-only follow-up to #1545: adds an end-to-end regression guard asserting that a
nameSource="derived"Claude name never overwrites the user's agent-deck session title.Why
#1545's rule is unit-tested at both links —
ClaudeSessionNameInmaps a derived name to"", andReconcileTitleFromClaudeno-ops on an empty name — but the composition was unpinned. A future refactor that resolves the name insideReconcileTitleFromClaudewithout going throughClaudeSessionName(e.g. inlining the metadata read, or adding a second name source) could reintroduce the "sessions renamed to folder name" clobbering while every existing test stays green.TestReconcileTitleFromClaude_NoopWhenDeriveddrives the real reconcile path against a seeded derived-name session file under an isolated$HOMEand asserts both the return contract ("", false) and thatInstance.Titlesurvives.No production code changes, no CHANGELOG entry (test-only).